Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HSI: nokia-modem: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

authored by

Julia Lawall and committed by
Sebastian Reichel
b2249129 c517d838

+1
+1
drivers/hsi/clients/nokia-modem.c
··· 200 200 modem->ssi_protocol = hsi_new_client(port, &ssip); 201 201 if (!modem->ssi_protocol) { 202 202 dev_err(dev, "Could not register ssi-protocol device\n"); 203 + err = -ENOMEM; 203 204 goto error2; 204 205 } 205 206