Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging:wlan-ng:hfa384x.h: remove typedef struct hfa384x_bytestr __packed hfa384x_bytestr_t

This patch removes the checkpatch.pl warning "do not add new typedefs"
and changes all source files that use that typedef. Also lines were
shortened to 80 characters to do away with the checkpatch.pl warning
"line over 80 characters" generated due to replacement of the
hfa384x_bytestr_t by struct hfa384x_bytestr in prism2mgmt.c,
prism2mgmt.h, prism2mib.c, prism2sta.c.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Himangi Saraogi and committed by
Greg Kroah-Hartman
b2119911 bb1da756

+15 -11
+2 -2
drivers/staging/wlan-ng/hfa384x.h
··· 350 350 351 351 /*-------------------------------------------------------------*/ 352 352 /* Commonly used basic types */ 353 - typedef struct hfa384x_bytestr { 353 + struct hfa384x_bytestr { 354 354 u16 len; 355 355 u8 data[0]; 356 - } __packed hfa384x_bytestr_t; 356 + } __packed; 357 357 358 358 typedef struct hfa384x_bytestr32 { 359 359 u16 len;
+2 -2
drivers/staging/wlan-ng/prism2mgmt.c
··· 525 525 526 526 p80211pstrd_t *pstr; 527 527 u8 bytebuf[80]; 528 - hfa384x_bytestr_t *p2bytestr = (hfa384x_bytestr_t *) bytebuf; 528 + struct hfa384x_bytestr *p2bytestr = (struct hfa384x_bytestr *) bytebuf; 529 529 u16 word; 530 530 531 531 wlandev->macmode = WLAN_MACMODE_NONE; ··· 1019 1019 struct p80211msg_lnxreq_autojoin *msg = msgp; 1020 1020 p80211pstrd_t *pstr; 1021 1021 u8 bytebuf[256]; 1022 - hfa384x_bytestr_t *p2bytestr = (hfa384x_bytestr_t *) bytebuf; 1022 + struct hfa384x_bytestr *p2bytestr = (struct hfa384x_bytestr *) bytebuf; 1023 1023 1024 1024 wlandev->macmode = WLAN_MACMODE_NONE; 1025 1025
+4 -2
drivers/staging/wlan-ng/prism2mgmt.h
··· 92 92 void prism2mgmt_bytearea2pstr(u8 *bytearea, p80211pstrd_t *pstr, int len); 93 93 94 94 /* byte string conversion functions*/ 95 - void prism2mgmt_pstr2bytestr(hfa384x_bytestr_t *bytestr, p80211pstrd_t *pstr); 96 - void prism2mgmt_bytestr2pstr(hfa384x_bytestr_t *bytestr, p80211pstrd_t *pstr); 95 + void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr, 96 + p80211pstrd_t *pstr); 97 + void prism2mgmt_bytestr2pstr(struct hfa384x_bytestr *bytestr, 98 + p80211pstrd_t *pstr); 97 99 98 100 /* functions to convert Group Addresses */ 99 101 void prism2mgmt_get_grpaddr(u32 did, p80211pstrd_t *pstr, hfa384x_t *priv);
+4 -2
drivers/staging/wlan-ng/prism2mib.c
··· 763 763 * 764 764 ----------------------------------------------------------------*/ 765 765 766 - void prism2mgmt_pstr2bytestr(hfa384x_bytestr_t *bytestr, p80211pstrd_t *pstr) 766 + void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr, 767 + p80211pstrd_t *pstr) 767 768 { 768 769 bytestr->len = cpu_to_le16((u16) (pstr->len)); 769 770 memcpy(bytestr->data, pstr->data, pstr->len); ··· 805 804 * 806 805 ----------------------------------------------------------------*/ 807 806 808 - void prism2mgmt_bytestr2pstr(hfa384x_bytestr_t *bytestr, p80211pstrd_t *pstr) 807 + void prism2mgmt_bytestr2pstr(struct hfa384x_bytestr *bytestr, 808 + p80211pstrd_t *pstr) 809 809 { 810 810 pstr->len = (u8) (le16_to_cpu((u16) (bytestr->len))); 811 811 memcpy(pstr->data, bytestr->data, pstr->len);
+3 -3
drivers/staging/wlan-ng/prism2sta.c
··· 1279 1279 HFA384x_RID_CURRENTSSID, result); 1280 1280 return; 1281 1281 } 1282 - prism2mgmt_bytestr2pstr((hfa384x_bytestr_t *) &ssid, 1282 + prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *) &ssid, 1283 1283 (p80211pstrd_t *) & 1284 1284 wlandev->ssid); 1285 1285 ··· 1361 1361 HFA384x_RID_CURRENTSSID, result); 1362 1362 return; 1363 1363 } 1364 - prism2mgmt_bytestr2pstr((hfa384x_bytestr_t *) &ssid, 1364 + prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *) &ssid, 1365 1365 (p80211pstrd_t *) &wlandev->ssid); 1366 1366 1367 1367 hw->link_status = HFA384x_LINK_CONNECTED; ··· 2037 2037 HFA384x_RID_CURRENTSSID, result); 2038 2038 return; 2039 2039 } 2040 - prism2mgmt_bytestr2pstr((hfa384x_bytestr_t *) &ssid, 2040 + prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *) &ssid, 2041 2041 (p80211pstrd_t *) &wlandev->ssid); 2042 2042 2043 2043 /* Reschedule timer */