Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Cai Huoqing and committed by
David S. Miller
b20b54fb 3503e673

+3 -4
+3 -4
drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
··· 171 171 int err; 172 172 173 173 dwmac->phy_ref_clk = devm_clk_get(&pdev->dev, "phy_ref_clk"); 174 - if (IS_ERR(dwmac->phy_ref_clk)) { 175 - dev_err(&pdev->dev, "phy_ref_clk clock not found.\n"); 176 - return PTR_ERR(dwmac->phy_ref_clk); 177 - } 174 + if (IS_ERR(dwmac->phy_ref_clk)) 175 + return dev_err_probe(&pdev->dev, PTR_ERR(dwmac->phy_ref_clk), 176 + "phy_ref_clk clock not found.\n"); 178 177 179 178 err = clk_prepare_enable(dwmac->phy_ref_clk); 180 179 if (err < 0) {