Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/zte: Use drm_atomic_helper_shutdown

drm_plane_helper_disable is a non-atomic drivers only function, and
will blow up (since no one passes the locking context it needs).

Atomic drivers which want to quiescent their hw on unload should
use drm_atomic_helper_shutdown() instead.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Shawn Guo <shawnguo@kernel.org>
Acked-by: Shawn Guo <shawnguo@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20181004202446.22905-15-daniel.vetter@ffwll.ch

+1 -1
+1
drivers/gpu/drm/zte/zx_drm_drv.c
··· 124 124 125 125 drm_dev_unregister(drm); 126 126 drm_kms_helper_poll_fini(drm); 127 + drm_atomic_helper_shutdown(drm); 127 128 drm_mode_config_cleanup(drm); 128 129 component_unbind_all(dev, drm); 129 130 dev_set_drvdata(dev, NULL);
-1
drivers/gpu/drm/zte/zx_plane.c
··· 446 446 447 447 static void zx_plane_destroy(struct drm_plane *plane) 448 448 { 449 - drm_plane_helper_disable(plane, NULL); 450 449 drm_plane_cleanup(plane); 451 450 } 452 451