Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

extcon: max8997: select IRQ_DOMAIN instead of depending on it

IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
it directly thru "make *config", so drivers should select it instead
of depending on it if they need it.
Relying on it being set for a dependency is risky.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change EXTCON_MAX8997's use of "depends on" for
IRQ_DOMAIN to "select".

Link: https://lore.kernel.org/lkml/20240213060028.9744-1-rdunlap@infradead.org/
Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

authored by

Randy Dunlap and committed by
Chanwoo Choi
b1781d0a 217f0362

+2 -1
+2 -1
drivers/extcon/Kconfig
··· 116 116 117 117 config EXTCON_MAX8997 118 118 tristate "Maxim MAX8997 EXTCON Support" 119 - depends on MFD_MAX8997 && IRQ_DOMAIN 119 + depends on MFD_MAX8997 120 + select IRQ_DOMAIN 120 121 help 121 122 If you say yes here you get support for the MUIC device of 122 123 Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory