Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Revert "soc: qcom: smd-rpm: Match rpmsg channel instead of compatible"

The rpm_requests device nodes have the compatible node. As such the
rpmsg core uses OF modalias instead of a native rpmsg modalias. Thus if
smd-rpm is built as a module, it doesn't get autoloaded for the device.

Revert the commit bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel
instead of compatible")

Fixes: bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel instead of compatible")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240729-fix-smd-rpm-v2-1-0776408a94c5@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Dmitry Baryshkov and committed by
Bjorn Andersson
b1715513 d4d4049e

+26 -9
+26 -9
drivers/soc/qcom/smd-rpm.c
··· 196 196 { 197 197 struct qcom_smd_rpm *rpm; 198 198 199 - if (!rpdev->dev.of_node) 200 - return -EINVAL; 201 - 202 199 rpm = devm_kzalloc(&rpdev->dev, sizeof(*rpm), GFP_KERNEL); 203 200 if (!rpm) 204 201 return -ENOMEM; ··· 215 218 of_platform_depopulate(&rpdev->dev); 216 219 } 217 220 218 - static const struct rpmsg_device_id qcom_smd_rpm_id_table[] = { 219 - { .name = "rpm_requests", }, 220 - { /* sentinel */ } 221 + static const struct of_device_id qcom_smd_rpm_of_match[] = { 222 + { .compatible = "qcom,rpm-apq8084" }, 223 + { .compatible = "qcom,rpm-ipq6018" }, 224 + { .compatible = "qcom,rpm-ipq9574" }, 225 + { .compatible = "qcom,rpm-msm8226" }, 226 + { .compatible = "qcom,rpm-msm8909" }, 227 + { .compatible = "qcom,rpm-msm8916" }, 228 + { .compatible = "qcom,rpm-msm8936" }, 229 + { .compatible = "qcom,rpm-msm8953" }, 230 + { .compatible = "qcom,rpm-msm8974" }, 231 + { .compatible = "qcom,rpm-msm8976" }, 232 + { .compatible = "qcom,rpm-msm8994" }, 233 + { .compatible = "qcom,rpm-msm8996" }, 234 + { .compatible = "qcom,rpm-msm8998" }, 235 + { .compatible = "qcom,rpm-sdm660" }, 236 + { .compatible = "qcom,rpm-sm6115" }, 237 + { .compatible = "qcom,rpm-sm6125" }, 238 + { .compatible = "qcom,rpm-sm6375" }, 239 + { .compatible = "qcom,rpm-qcm2290" }, 240 + { .compatible = "qcom,rpm-qcs404" }, 241 + {} 221 242 }; 222 - MODULE_DEVICE_TABLE(rpmsg, qcom_smd_rpm_id_table); 243 + MODULE_DEVICE_TABLE(of, qcom_smd_rpm_of_match); 223 244 224 245 static struct rpmsg_driver qcom_smd_rpm_driver = { 225 246 .probe = qcom_smd_rpm_probe, 226 247 .remove = qcom_smd_rpm_remove, 227 248 .callback = qcom_smd_rpm_callback, 228 - .id_table = qcom_smd_rpm_id_table, 229 - .drv.name = "qcom_smd_rpm", 249 + .drv = { 250 + .name = "qcom_smd_rpm", 251 + .of_match_table = qcom_smd_rpm_of_match, 252 + }, 230 253 }; 231 254 232 255 static int __init qcom_smd_rpm_init(void)