Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf tools: Fix mmap2 event allocation in synthesize code

perf_event__synthesize_mmap_events() issues mmap2 events, but the memory
of that event is allocated using:

mmap_event = malloc(sizeof(mmap_event->mmap) + machine->id_hdr_size);

If path of mmap source file is long (near PATH_MAX), random crash would
happen. Should use sizeof(mmap_event->mmap2).

Fix two memory allocations.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: He Kuang <hekuang@huawei.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1452593524-138970-1-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Wang Nan and committed by
Arnaldo Carvalho de Melo
b0fb978e 8a59f3cc

+2 -2
+2 -2
tools/perf/util/event.c
··· 503 503 if (comm_event == NULL) 504 504 goto out; 505 505 506 - mmap_event = malloc(sizeof(mmap_event->mmap) + machine->id_hdr_size); 506 + mmap_event = malloc(sizeof(mmap_event->mmap2) + machine->id_hdr_size); 507 507 if (mmap_event == NULL) 508 508 goto out_free_comm; 509 509 ··· 577 577 if (comm_event == NULL) 578 578 goto out; 579 579 580 - mmap_event = malloc(sizeof(mmap_event->mmap) + machine->id_hdr_size); 580 + mmap_event = malloc(sizeof(mmap_event->mmap2) + machine->id_hdr_size); 581 581 if (mmap_event == NULL) 582 582 goto out_free_comm; 583 583