Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: 6852/1: EP93xx: Remove ep93xx_gpio_dbg_show function

The interrupt printing functionality in the ep93xx gpio debugfs function
does not behave as expected. It prints [interrupt] beside all pins which
are capable of being interrupts, not just those which are currently
configured as interrupts.

The best solution is just to remove the custom ep93xx gpio debugfs
function all together. The generic gpiolib one is good enough.

Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

authored by

Ryan Mallon and committed by
Russell King
b0ec5cf1 9f381a61

-24
-24
arch/arm/mach-ep93xx/gpio.c
··· 356 356 return 0; 357 357 } 358 358 359 - static void ep93xx_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) 360 - { 361 - struct ep93xx_gpio_chip *ep93xx_chip = to_ep93xx_gpio_chip(chip); 362 - u8 data_reg, data_dir_reg; 363 - int gpio, i; 364 - 365 - data_reg = __raw_readb(ep93xx_chip->data_reg); 366 - data_dir_reg = __raw_readb(ep93xx_chip->data_dir_reg); 367 - 368 - gpio = ep93xx_chip->chip.base; 369 - for (i = 0; i < chip->ngpio; i++, gpio++) { 370 - int is_out = data_dir_reg & (1 << i); 371 - int irq = gpio_to_irq(gpio); 372 - 373 - seq_printf(s, " %s%d gpio-%-3d (%-12s) %s %s %s\n", 374 - chip->label, i, gpio, 375 - gpiochip_is_requested(chip, i) ? : "", 376 - is_out ? "out" : "in ", 377 - (data_reg & (1<< i)) ? "hi" : "lo", 378 - (!is_out && irq>= 0) ? "(interrupt)" : ""); 379 - } 380 - } 381 - 382 359 #define EP93XX_GPIO_BANK(name, dr, ddr, base_gpio) \ 383 360 { \ 384 361 .chip = { \ ··· 364 387 .direction_output = ep93xx_gpio_direction_output, \ 365 388 .get = ep93xx_gpio_get, \ 366 389 .set = ep93xx_gpio_set, \ 367 - .dbg_show = ep93xx_gpio_dbg_show, \ 368 390 .base = base_gpio, \ 369 391 .ngpio = 8, \ 370 392 }, \