kprobes: fix kill kprobe which has been marked as gone

If a kprobe is marked as gone, we should not kill it again. Otherwise, we
can disarm the kprobe more than once. In that case, the statistics of
kprobe_ftrace_enabled can unbalance which can lead to that kprobe do not
work.

Fixes: e8386a0cb22f ("kprobes: support probing module __exit function")
Co-developed-by: Chengming Zhou <[e-mail]>
Signed-off-by: Muchun Song <[e-mail]>
Signed-off-by: Chengming Zhou <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
Acked-by: Masami Hiramatsu <[e-mail]>
Cc: "Naveen N . Rao" <[e-mail]>
Cc: Anil S Keshavamurthy <[e-mail]>
Cc: David S. Miller <[e-mail]>
Cc: Song Liu <[e-mail]>
Cc: Steven Rostedt <[e-mail]>
Cc: <[e-mail]>
Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Linus Torvalds <[e-mail]>

kernel/kprobes.c

···
 
 	lockdep_assert_held(&kprobe_mutex);
 
+	if (WARN_ON_ONCE(kprobe_gone(p)))
+		return;
+
 	p->flags |= KPROBE_FLAG_GONE;
 	if (kprobe_aggrprobe(p)) {
 		/*
···
 	mutex_lock(&kprobe_mutex);
 	for (i = 0; i < KPROBE_TABLE_SIZE; i++) {
 		head = &kprobe_table[i];
-		hlist_for_each_entry(p, head, hlist)
+		hlist_for_each_entry(p, head, hlist) {
+			if (kprobe_gone(p))
+				continue;
+
 			if (within_module_init((unsigned long)p->addr, mod) ||
 			    (checkcore &&
 			     within_module_core((unsigned long)p->addr, mod))) {
···
 				 */
 				kill_kprobe(p);
 			}
+		}
 	}
 	if (val == MODULE_STATE_GOING)
 		remove_module_kprobe_blacklist(mod);