Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

V4L/DVB (7293): DMX_OUT_TSDEMUX_TAP: record two streams from same mux, resend

Currently (in linux-2.6.24, but linux-dvb hg looks similar), the
dmx_output_t in the dmx_pes_filter_params decides two things: whether
output is sent to demux0 or dvr0 (in dmxdev.c:dvb_dmxdev_ts_callback),
*and* whether to depacketise TS (in dmxdev.c:dvb_dmxdev_filter_start).
As it stands, those two things can't be set independently: output
destined for demux0 is depacketised, output for dvr0 isn't.

This is what you want for capturing multiple audio streams from the same
multiplex simultaneously: open demux0 several times and send
depacketised output there. And capturing a single video stream is fine
not what you want: you want multi-open (so demux0, not dvr0), but you
want the TS nature preserved (because that's what you want on output, as
you're going to re-multiplex it with the audio).

At least one existing solution -- GStreamer -- sends all its streams
simultaneously via dvr0 and demuxes again in userland, but it seems a
bit of a shame to pick out all the PIDs in kernel, stick them back
together in kernel, and send them to userland only to get unpicked
again, when the alternative is such a small API addition.

The attached patch adds a new value for dmx_output_t:
DMX_OUT_TSDEMUX_TAP, which sends TS to the demux0 device. With this
patch and a dvb-usb-dib0700 (and UK Freeview from Sandy Heath), I can
successfully capture an audio/video PID pair into a TS file that mplayer
can play back.

Signed-off-by: Peter Hartley <pdh@utter.chaos.org.uk>
Acked-by: Andreas Oberritter <obi@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

authored by

Peter Hartley and committed by
Mauro Carvalho Chehab
b01cd937 3c66e4e1

+5 -3
+3 -2
drivers/media/dvb/dvb-core/dmxdev.c
··· 374 374 return 0; 375 375 } 376 376 377 - if (dmxdevfilter->params.pes.output == DMX_OUT_TAP) 377 + if (dmxdevfilter->params.pes.output == DMX_OUT_TAP 378 + || dmxdevfilter->params.pes.output == DMX_OUT_TSDEMUX_TAP) 378 379 buffer = &dmxdevfilter->buffer; 379 380 else 380 381 buffer = &dmxdevfilter->dev->dvr_buffer; ··· 619 618 else 620 619 ts_type = 0; 621 620 622 - if (otype == DMX_OUT_TS_TAP) 621 + if (otype == DMX_OUT_TS_TAP || otype == DMX_OUT_TSDEMUX_TAP) 623 622 ts_type |= TS_PACKET; 624 623 625 624 if (otype == DMX_OUT_TAP)
+2 -1
include/linux/dvb/dmx.h
··· 39 39 DMX_OUT_DECODER, /* Streaming directly to decoder. */ 40 40 DMX_OUT_TAP, /* Output going to a memory buffer */ 41 41 /* (to be retrieved via the read command).*/ 42 - DMX_OUT_TS_TAP /* Output multiplexed into a new TS */ 42 + DMX_OUT_TS_TAP, /* Output multiplexed into a new TS */ 43 43 /* (to be retrieved by reading from the */ 44 44 /* logical DVR device). */ 45 + DMX_OUT_TSDEMUX_TAP /* Like TS_TAP but retrieved from the DMX device */ 45 46 } dmx_output_t; 46 47 47 48