Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

vhost: Take a reference on the task in struct vhost_task.

vhost_task_create() creates a task and keeps a reference to its
task_struct. That task may exit early via a signal and its task_struct
will be released.
A pending vhost_task_wake() will then attempt to wake the task and
access a task_struct which is no longer there.

Acquire a reference on the task_struct while creating the thread and
release the reference while the struct vhost_task itself is removed.
If the task exits early due to a signal, then the vhost_task_wake() will
still access a valid task_struct. The wake is safe and will be skipped
in this case.

Fixes: f9010dbdce911 ("fork, vhost: Use CLONE_THREAD to fix freezer/ps regression")
Reported-by: Sean Christopherson <seanjc@google.com>
Closes: https://lore.kernel.org/all/aKkLEtoDXKxAAWju@google.com/
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Message-Id: <20250918181144.Ygo8BZ-R@linutronix.de>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Sean Christopherson <seanjc@google.com>

authored by

Sebastian Andrzej Siewior and committed by
Michael S. Tsirkin
afe16653 e4304516

+2 -1
+2 -1
kernel/vhost_task.c
··· 100 100 * freeing it below. 101 101 */ 102 102 wait_for_completion(&vtsk->exited); 103 + put_task_struct(vtsk->task); 103 104 kfree(vtsk); 104 105 } 105 106 EXPORT_SYMBOL_GPL(vhost_task_stop); ··· 149 148 return ERR_CAST(tsk); 150 149 } 151 150 152 - vtsk->task = tsk; 151 + vtsk->task = get_task_struct(tsk); 153 152 return vtsk; 154 153 } 155 154 EXPORT_SYMBOL_GPL(vhost_task_create);