Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc/pseries: fix possible memory leak in ibmebus_bus_init()

If device_register() returns error in ibmebus_bus_init(), name of kobject
which is allocated in dev_set_name() called in device_add() is leaked.

As comment of device_add() says, it should call put_device() to drop
the reference count that was set in device_initialize() when it fails,
so the name can be freed in kobject_cleanup().

Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20221110011929.3709774-1-ruanjinjie@huawei.com

authored by

ruanjinjie and committed by
Michael Ellerman
afda85b9 efa1f850

+1
+1
arch/powerpc/platforms/pseries/ibmebus.c
··· 461 461 if (err) { 462 462 printk(KERN_WARNING "%s: device_register returned %i\n", 463 463 __func__, err); 464 + put_device(&ibmebus_bus_device); 464 465 bus_unregister(&ibmebus_bus_type); 465 466 466 467 return err;