Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftest: net: fix socklen_t type mismatch in sctp_collision test

Socket APIs like recvfrom(), accept(), and getsockname() expect socklen_t*
arg, but tests were using int variables. This causes -Wpointer-sign
warnings on platforms where socklen_t is unsigned.

Change the variable type from int to socklen_t to resolve the warning and
ensure type safety across platforms.

warning fixed:

sctp_collision.c:62:70: warning: passing 'int *' to parameter of
type 'socklen_t *' (aka 'unsigned int *') converts between pointers to
integer types with different sign [-Wpointer-sign]
62 | ret = recvfrom(sd, buf, sizeof(buf),
0, (struct sockaddr *)&daddr, &len);
| ^~~~
/usr/include/sys/socket.h:165:27: note: passing argument to
parameter '__addr_len' here
165 | socklen_t *__restrict __addr_len);
| ^

Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Ankit Khushwaha <ankitkhushwaha.linux@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251028172947.53153-1-ankitkhushwaha.linux@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Ankit Khushwaha and committed by
Jakub Kicinski
afb8f656 efd3e30e

+2 -1
+2 -1
tools/testing/selftests/net/netfilter/sctp_collision.c
··· 9 9 int main(int argc, char *argv[]) 10 10 { 11 11 struct sockaddr_in saddr = {}, daddr = {}; 12 - int sd, ret, len = sizeof(daddr); 12 + socklen_t len = sizeof(daddr); 13 13 struct timeval tv = {25, 0}; 14 14 char buf[] = "hello"; 15 + int sd, ret; 15 16 16 17 if (argc != 6 || (strcmp(argv[1], "server") && strcmp(argv[1], "client"))) { 17 18 printf("%s <server|client> <LOCAL_IP> <LOCAL_PORT> <REMOTE_IP> <REMOTE_PORT>\n",