Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/chrome: cros_ec: Make cros_ec_unregister() return void

Up to now cros_ec_unregister() returns zero unconditionally. Make it
return void instead which makes it easier to see in the callers that
there is no error to handle.

Also the return value of i2c, platform and spi remove callbacks is
ignored anyway.

Reviewed-by: Guenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/20211020071753.wltjslmimb6wtlp5@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220123175201.34839-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
afb0a80e 316f569d

+11 -7
+1 -3
drivers/platform/chrome/cros_ec.c
··· 302 302 * 303 303 * Return: 0 on success or negative error code. 304 304 */ 305 - int cros_ec_unregister(struct cros_ec_device *ec_dev) 305 + void cros_ec_unregister(struct cros_ec_device *ec_dev) 306 306 { 307 307 if (ec_dev->pd) 308 308 platform_device_unregister(ec_dev->pd); 309 309 platform_device_unregister(ec_dev->ec); 310 - 311 - return 0; 312 310 } 313 311 EXPORT_SYMBOL(cros_ec_unregister); 314 312
+1 -1
drivers/platform/chrome/cros_ec.h
··· 11 11 #include <linux/interrupt.h> 12 12 13 13 int cros_ec_register(struct cros_ec_device *ec_dev); 14 - int cros_ec_unregister(struct cros_ec_device *ec_dev); 14 + void cros_ec_unregister(struct cros_ec_device *ec_dev); 15 15 16 16 int cros_ec_suspend(struct cros_ec_device *ec_dev); 17 17 int cros_ec_resume(struct cros_ec_device *ec_dev);
+3 -1
drivers/platform/chrome/cros_ec_i2c.c
··· 313 313 { 314 314 struct cros_ec_device *ec_dev = i2c_get_clientdata(client); 315 315 316 - return cros_ec_unregister(ec_dev); 316 + cros_ec_unregister(ec_dev); 317 + 318 + return 0; 317 319 } 318 320 319 321 #ifdef CONFIG_PM_SLEEP
+3 -1
drivers/platform/chrome/cros_ec_lpc.c
··· 439 439 acpi_remove_notify_handler(adev->handle, ACPI_ALL_NOTIFY, 440 440 cros_ec_lpc_acpi_notify); 441 441 442 - return cros_ec_unregister(ec_dev); 442 + cros_ec_unregister(ec_dev); 443 + 444 + return 0; 443 445 } 444 446 445 447 static const struct acpi_device_id cros_ec_lpc_acpi_device_ids[] = {
+3 -1
drivers/platform/chrome/cros_ec_spi.c
··· 790 790 { 791 791 struct cros_ec_device *ec_dev = spi_get_drvdata(spi); 792 792 793 - return cros_ec_unregister(ec_dev); 793 + cros_ec_unregister(ec_dev); 794 + 795 + return 0; 794 796 } 795 797 796 798 #ifdef CONFIG_PM_SLEEP