tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
USB: serial: kobil_sct: add missing version error handling
Add missing version-request error handling and suppress printing of the
(zeroed) transfer-buffer content in case of errors.
Signed-off-by: Johan Hovold <johan@kernel.org>
+8
-4
+8
-4
drivers/usb/serial/kobil_sct.c
+8
-4
drivers/usb/serial/kobil_sct.c
···
190
190
KOBIL_TIMEOUT
191
191
);
192
192
dev_dbg(dev, "%s - Send get_HW_version URB returns: %i\n", __func__, result);
193
-
dev_dbg(dev, "Hardware version: %i.%i.%i\n", transfer_buffer[0],
194
-
transfer_buffer[1], transfer_buffer[2]);
193
+
if (result >= 3) {
194
+
dev_dbg(dev, "Hardware version: %i.%i.%i\n", transfer_buffer[0],
195
+
transfer_buffer[1], transfer_buffer[2]);
196
+
}
195
197
196
198
/* get firmware version */
197
199
result = usb_control_msg(port->serial->dev,
···
207
205
KOBIL_TIMEOUT
208
206
);
209
207
dev_dbg(dev, "%s - Send get_FW_version URB returns: %i\n", __func__, result);
210
-
dev_dbg(dev, "Firmware version: %i.%i.%i\n", transfer_buffer[0],
211
-
transfer_buffer[1], transfer_buffer[2]);
208
+
if (result >= 3) {
209
+
dev_dbg(dev, "Firmware version: %i.%i.%i\n", transfer_buffer[0],
210
+
transfer_buffer[1], transfer_buffer[2]);
211
+
}
212
212
213
213
if (priv->device_type == KOBIL_ADAPTER_B_PRODUCT_ID ||
214
214
priv->device_type == KOBIL_ADAPTER_K_PRODUCT_ID) {