Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: dbx500: Remove use of seq_puts/seq_printf return value

The seq_puts/seq_printf return value, because it's frequently misused,
will eventually be converted to void.

See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
seq_has_overflowed() and make public")

Miscellanea:

o Remove unnecessary dev_err("seq_<foo> overflow\n") messages

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Joe Perches and committed by
Mark Brown
af78114e c517d838

+9 -23
+9 -23
drivers/regulator/dbx500-prcmu.c
··· 95 95 96 96 static int ux500_regulator_power_state_cnt_print(struct seq_file *s, void *p) 97 97 { 98 - struct device *dev = s->private; 99 - int err; 100 - 101 98 /* print power state count */ 102 - err = seq_printf(s, "ux500-regulator power state count: %i\n", 103 - power_state_active_get()); 104 - if (err < 0) 105 - dev_err(dev, "seq_printf overflow\n"); 99 + seq_printf(s, "ux500-regulator power state count: %i\n", 100 + power_state_active_get()); 106 101 107 102 return 0; 108 103 } ··· 119 124 120 125 static int ux500_regulator_status_print(struct seq_file *s, void *p) 121 126 { 122 - struct device *dev = s->private; 123 - int err; 124 127 int i; 125 128 126 129 /* print dump header */ 127 - err = seq_puts(s, "ux500-regulator status:\n"); 128 - if (err < 0) 129 - dev_err(dev, "seq_puts overflow\n"); 130 - 131 - err = seq_printf(s, "%31s : %8s : %8s\n", "current", 132 - "before", "after"); 133 - if (err < 0) 134 - dev_err(dev, "seq_printf overflow\n"); 130 + seq_puts(s, "ux500-regulator status:\n"); 131 + seq_printf(s, "%31s : %8s : %8s\n", "current", "before", "after"); 135 132 136 133 for (i = 0; i < rdebug.num_regulators; i++) { 137 134 struct dbx500_regulator_info *info; ··· 131 144 info = &rdebug.regulator_array[i]; 132 145 133 146 /* print status */ 134 - err = seq_printf(s, "%20s : %8s : %8s : %8s\n", info->desc.name, 135 - info->is_enabled ? "enabled" : "disabled", 136 - rdebug.state_before_suspend[i] ? "enabled" : "disabled", 137 - rdebug.state_after_suspend[i] ? "enabled" : "disabled"); 138 - if (err < 0) 139 - dev_err(dev, "seq_printf overflow\n"); 147 + seq_printf(s, "%20s : %8s : %8s : %8s\n", 148 + info->desc.name, 149 + info->is_enabled ? "enabled" : "disabled", 150 + rdebug.state_before_suspend[i] ? "enabled" : "disabled", 151 + rdebug.state_after_suspend[i] ? "enabled" : "disabled"); 140 152 } 141 153 142 154 return 0;