Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

of: Improve of_phandle_iterator_next() error message

Understanding why of_phandle_iterator_next() returns an error can
sometimes be hard to decipher based solely on the error message, a
typical error example is that #foo-cells = <X> and the phandle property
used has a smaller number of cells specified, e.g.:

#thermal-sensor-cells = <1>;
phandle = <&scmi_sensor>

instead of:

phandle <&scmi_sensor 0>;

Instead, make it clear what the expectations are towards debugging
incorrect Device Tree faster:

OF: /thermal-zones/scmi-thermal: #thermal-sensor-cells = 1, found 0 instead

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>

authored by

Florian Fainelli and committed by
Rob Herring
af3be70a 12eeae71

+3 -2
+3 -2
drivers/of/base.c
··· 1350 1350 * property data length 1351 1351 */ 1352 1352 if (it->cur + count > it->list_end) { 1353 - pr_err("%pOF: arguments longer than property\n", 1354 - it->parent); 1353 + pr_err("%pOF: %s = %d found %d\n", 1354 + it->parent, it->cells_name, 1355 + count, it->cell_count); 1355 1356 goto err; 1356 1357 } 1357 1358 }