Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] omap-rng build fix

Seems like the omap-rng driver in the main tree predates the switch from
<asm/hardware/clock.h> to <linux/clk.h> ... now it builds OK.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

David Brownell and committed by
Linus Torvalds
af2bc7d2 b0b33dee

+24 -27
+24 -27
drivers/char/hw_random/omap-rng.c
··· 25 25 #include <linux/module.h> 26 26 #include <linux/init.h> 27 27 #include <linux/random.h> 28 + #include <linux/clk.h> 28 29 #include <linux/err.h> 29 - #include <linux/device.h> 30 + #include <linux/platform_device.h> 30 31 #include <linux/hw_random.h> 31 32 32 33 #include <asm/io.h> 33 - #include <asm/hardware/clock.h> 34 34 35 35 #define RNG_OUT_REG 0x00 /* Output register */ 36 36 #define RNG_STAT_REG 0x04 /* Status register ··· 52 52 53 53 static void __iomem *rng_base; 54 54 static struct clk *rng_ick; 55 - static struct device *rng_dev; 55 + static struct platform_device *rng_dev; 56 56 57 57 static u32 omap_rng_read_reg(int reg) 58 58 { ··· 83 83 .data_read = omap_rng_data_read, 84 84 }; 85 85 86 - static int __init omap_rng_probe(struct device *dev) 86 + static int __init omap_rng_probe(struct platform_device *pdev) 87 87 { 88 - struct platform_device *pdev = to_platform_device(dev); 89 88 struct resource *res, *mem; 90 89 int ret; 91 90 ··· 94 95 */ 95 96 BUG_ON(rng_dev); 96 97 97 - if (cpu_is_omap24xx()) { 98 + if (cpu_is_omap24xx()) { 98 99 rng_ick = clk_get(NULL, "rng_ick"); 99 100 if (IS_ERR(rng_ick)) { 100 - dev_err(dev, "Could not get rng_ick\n"); 101 + dev_err(&pdev->dev, "Could not get rng_ick\n"); 101 102 ret = PTR_ERR(rng_ick); 102 103 return ret; 103 - } 104 - else { 105 - clk_use(rng_ick); 106 - } 104 + } else 105 + clk_enable(rng_ick); 107 106 } 108 107 109 108 res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ··· 114 117 if (mem == NULL) 115 118 return -EBUSY; 116 119 117 - dev_set_drvdata(dev, mem); 120 + dev_set_drvdata(&pdev->dev, mem); 118 121 rng_base = (u32 __iomem *)io_p2v(res->start); 119 122 120 123 ret = hwrng_register(&omap_rng_ops); ··· 124 127 return ret; 125 128 } 126 129 127 - dev_info(dev, "OMAP Random Number Generator ver. %02x\n", 130 + dev_info(&pdev->dev, "OMAP Random Number Generator ver. %02x\n", 128 131 omap_rng_read_reg(RNG_REV_REG)); 129 132 omap_rng_write_reg(RNG_MASK_REG, 0x1); 130 133 131 - rng_dev = dev; 134 + rng_dev = pdev; 132 135 133 136 return 0; 134 137 } 135 138 136 - static int __exit omap_rng_remove(struct device *dev) 139 + static int __exit omap_rng_remove(struct platform_device *pdev) 137 140 { 138 - struct resource *mem = dev_get_drvdata(dev); 141 + struct resource *mem = dev_get_drvdata(&pdev->dev); 139 142 140 143 hwrng_unregister(&omap_rng_ops); 141 144 142 145 omap_rng_write_reg(RNG_MASK_REG, 0x0); 143 146 144 147 if (cpu_is_omap24xx()) { 145 - clk_unuse(rng_ick); 148 + clk_disable(rng_ick); 146 149 clk_put(rng_ick); 147 150 } 148 151 ··· 154 157 155 158 #ifdef CONFIG_PM 156 159 157 - static int omap_rng_suspend(struct device *dev, pm_message_t message, u32 level) 160 + static int omap_rng_suspend(struct platform_device *pdev, pm_message_t message) 158 161 { 159 162 omap_rng_write_reg(RNG_MASK_REG, 0x0); 160 - 161 163 return 0; 162 164 } 163 165 164 - static int omap_rng_resume(struct device *dev, pm_message_t message, u32 level) 166 + static int omap_rng_resume(struct platform_device *pdev) 165 167 { 166 168 omap_rng_write_reg(RNG_MASK_REG, 0x1); 167 - 168 - return 1; 169 + return 0; 169 170 } 170 171 171 172 #else ··· 174 179 #endif 175 180 176 181 177 - static struct device_driver omap_rng_driver = { 178 - .name = "omap_rng", 179 - .bus = &platform_bus_type, 182 + static struct platform_driver omap_rng_driver = { 183 + .driver = { 184 + .name = "omap_rng", 185 + .owner = THIS_MODULE, 186 + }, 180 187 .probe = omap_rng_probe, 181 188 .remove = __exit_p(omap_rng_remove), 182 189 .suspend = omap_rng_suspend, ··· 190 193 if (!cpu_is_omap16xx() && !cpu_is_omap24xx()) 191 194 return -ENODEV; 192 195 193 - return driver_register(&omap_rng_driver); 196 + return platform_driver_register(&omap_rng_driver); 194 197 } 195 198 196 199 static void __exit omap_rng_exit(void) 197 200 { 198 - driver_unregister(&omap_rng_driver); 201 + platform_driver_unregister(&omap_rng_driver); 199 202 } 200 203 201 204 module_init(omap_rng_init);