Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: lsiio: fix error code handling error

commit acf50b3586f8d8a7530b905e111dda41876d38f4
"tools:iio:lsiio: add error handling"
introduced error handling of errors returned from
read_sysfs_string(), but with a simple if (retval),
missing the fact that these functions return a positive
value if the read was successful.

As a result lsiio regresses and does not show any
devices on my filesystem. Fix this by checking for
only negative error codes.

Cc: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

authored by

Linus Walleij and committed by
Jonathan Cameron
af255cd5 06d2f6ca

+2 -2
+2 -2
tools/iio/lsiio.c
··· 69 69 return -EINVAL; 70 70 71 71 ret = read_sysfs_string("name", dev_dir_name, name); 72 - if (ret) 72 + if (ret < 0) 73 73 return ret; 74 74 75 75 printf("Device %03d: %s\n", dev_idx, name); ··· 92 92 return -EINVAL; 93 93 94 94 ret = read_sysfs_string("name", dev_dir_name, name); 95 - if (ret) 95 + if (ret < 0) 96 96 return ret; 97 97 98 98 printf("Trigger %03d: %s\n", dev_idx, name);