Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915/rkl: Setup ports/phys

RKL uses DDI's A, B, TC1, and TC2 which need to map to combo PHY's A-D.

Bspec: 49181
Cc: Imre Deak <imre.deak@intel.com>
Cc: Aditya Swarup <aditya.swarup@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200603211529.3005059-6-matthew.d.roper@intel.com
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

+24 -14
+21 -13
drivers/gpu/drm/i915/display/intel_display.c
··· 7218 7218 { 7219 7219 if (phy == PHY_NONE) 7220 7220 return false; 7221 - 7222 - if (IS_ELKHARTLAKE(dev_priv)) 7221 + else if (IS_ROCKETLAKE(dev_priv)) 7222 + return phy <= PHY_D; 7223 + else if (IS_ELKHARTLAKE(dev_priv)) 7223 7224 return phy <= PHY_C; 7224 - 7225 - if (INTEL_GEN(dev_priv) >= 11) 7225 + else if (INTEL_GEN(dev_priv) >= 11) 7226 7226 return phy <= PHY_B; 7227 - 7228 - return false; 7227 + else 7228 + return false; 7229 7229 } 7230 7230 7231 7231 bool intel_phy_is_tc(struct drm_i915_private *dev_priv, enum phy phy) 7232 7232 { 7233 - if (INTEL_GEN(dev_priv) >= 12) 7233 + if (IS_ROCKETLAKE(dev_priv)) 7234 + return false; 7235 + else if (INTEL_GEN(dev_priv) >= 12) 7234 7236 return phy >= PHY_D && phy <= PHY_I; 7235 - 7236 - if (INTEL_GEN(dev_priv) >= 11 && !IS_ELKHARTLAKE(dev_priv)) 7237 + else if (INTEL_GEN(dev_priv) >= 11 && !IS_ELKHARTLAKE(dev_priv)) 7237 7238 return phy >= PHY_C && phy <= PHY_F; 7238 - 7239 - return false; 7239 + else 7240 + return false; 7240 7241 } 7241 7242 7242 7243 enum phy intel_port_to_phy(struct drm_i915_private *i915, enum port port) 7243 7244 { 7244 - if (IS_ELKHARTLAKE(i915) && port == PORT_D) 7245 + if (IS_ROCKETLAKE(i915) && port >= PORT_D) 7246 + return (enum phy)port - 1; 7247 + else if (IS_ELKHARTLAKE(i915) && port == PORT_D) 7245 7248 return PHY_A; 7246 7249 7247 7250 return (enum phy)port; ··· 16821 16818 if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) 16822 16819 return; 16823 16820 16824 - if (INTEL_GEN(dev_priv) >= 12) { 16821 + if (IS_ROCKETLAKE(dev_priv)) { 16822 + intel_ddi_init(dev_priv, PORT_A); 16823 + intel_ddi_init(dev_priv, PORT_B); 16824 + intel_ddi_init(dev_priv, PORT_D); /* DDI TC1 */ 16825 + intel_ddi_init(dev_priv, PORT_E); /* DDI TC2 */ 16826 + } else if (INTEL_GEN(dev_priv) >= 12) { 16825 16827 intel_ddi_init(dev_priv, PORT_A); 16826 16828 intel_ddi_init(dev_priv, PORT_B); 16827 16829 intel_ddi_init(dev_priv, PORT_D);
+3 -1
drivers/gpu/drm/i915/i915_reg.h
··· 1869 1869 #define _ICL_COMBOPHY_A 0x162000 1870 1870 #define _ICL_COMBOPHY_B 0x6C000 1871 1871 #define _EHL_COMBOPHY_C 0x160000 1872 + #define _RKL_COMBOPHY_D 0x161000 1872 1873 #define _ICL_COMBOPHY(phy) _PICK(phy, _ICL_COMBOPHY_A, \ 1873 1874 _ICL_COMBOPHY_B, \ 1874 - _EHL_COMBOPHY_C) 1875 + _EHL_COMBOPHY_C, \ 1876 + _RKL_COMBOPHY_D) 1875 1877 1876 1878 /* CNL/ICL Port CL_DW registers */ 1877 1879 #define _ICL_PORT_CL_DW(dw, phy) (_ICL_COMBOPHY(phy) + \