Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sfc: Miscellaneous comment removals

Remove comments that only apply to Falcon and Siena.

Signed-off-by: Martin Habets <habetsm.xilinx@gmail.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Martin Habets and committed by
David S. Miller
ae9d445c d73e7715

+2 -21
-5
drivers/net/ethernet/sfc/efx_common.c
··· 35 35 36 36 /* This is the time (in jiffies) between invocations of the hardware 37 37 * monitor. 38 - * On Falcon-based NICs, this will: 39 - * - Check the on-board hardware monitor; 40 - * - Poll the link state and reconfigure the hardware as necessary. 41 - * On Siena-based NICs for power systems with EEH support, this will give EEH a 42 - * chance to start. 43 38 */ 44 39 static unsigned int efx_monitor_interval = 1 * HZ; 45 40
-7
drivers/net/ethernet/sfc/filter.h
··· 30 30 * 31 31 * Only some combinations are supported, depending on NIC type: 32 32 * 33 - * - Falcon supports RX filters matching by {TCP,UDP}/IPv4 4-tuple or 34 - * local 2-tuple (only implemented for Falcon B0) 35 - * 36 - * - Siena supports RX and TX filters matching by {TCP,UDP}/IPv4 4-tuple 37 - * or local 2-tuple, or local MAC with or without outer VID, and RX 38 - * default filters 39 - * 40 33 * - Huntington supports filter matching controlled by firmware, potentially 41 34 * using {TCP,UDP}/IPv{4,6} 4-tuple or local 2-tuple, local MAC or I/G bit, 42 35 * with or without outer and inner VID
+1 -3
drivers/net/ethernet/sfc/nic_common.h
··· 79 79 80 80 /* Decide whether to push a TX descriptor to the NIC vs merely writing 81 81 * the doorbell. This can reduce latency when we are adding a single 82 - * descriptor to an empty queue, but is otherwise pointless. Further, 83 - * Falcon and Siena have hardware bugs (SF bug 33851) that may be 84 - * triggered if we don't check this. 82 + * descriptor to an empty queue, but is otherwise pointless. 85 83 * We use the write_count used for the last doorbell push, to get the 86 84 * NIC's view of the tx queue. 87 85 */
+1 -6
drivers/net/ethernet/sfc/selftest.c
··· 38 38 /* 39 39 * Loopback test packet structure 40 40 * 41 - * The self-test should stress every RSS vector, and unfortunately 42 - * Falcon only performs RSS on TCP/UDP packets. 41 + * The self-test should stress every RSS vector. 43 42 */ 44 43 struct efx_loopback_payload { 45 44 char pad[2]; /* Ensures ip is 4-byte aligned */ ··· 580 581 return 0; 581 582 } 582 583 583 - /* Wait for link up. On Falcon, we would prefer to rely on efx_monitor, but 584 - * any contention on the mac lock (via e.g. efx_mac_mcast_work) causes it 585 - * to delay and retry. Therefore, it's safer to just poll directly. Wait 586 - * for link up and any faults to dissipate. */ 587 584 static int efx_wait_for_link(struct efx_nic *efx) 588 585 { 589 586 struct efx_link_state *link_state = &efx->link_state;