Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: mediatek: reset: Return regmap's error code

device_node_to_regmap() can return different errors, and it's better
practice to pass them to callers.

Clean up the hardcoded -EINVAL and use PTR_ERR(regmap) instead.

Signed-off-by: Fei Shao <fshao@chromium.org>
Link: https://lore.kernel.org/r/20240717115919.975474-1-fshao@chromium.org
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Fei Shao and committed by
Stephen Boyd
ae8ca031 8400291e

+2 -2
+2 -2
drivers/clk/mediatek/reset.c
··· 138 138 regmap = device_node_to_regmap(np); 139 139 if (IS_ERR(regmap)) { 140 140 pr_err("Cannot find regmap for %pOF: %pe\n", np, regmap); 141 - return -EINVAL; 141 + return PTR_ERR(regmap); 142 142 } 143 143 144 144 data = kzalloc(sizeof(*data), GFP_KERNEL); ··· 198 198 regmap = device_node_to_regmap(np); 199 199 if (IS_ERR(regmap)) { 200 200 dev_err(dev, "Cannot find regmap %pe\n", regmap); 201 - return -EINVAL; 201 + return PTR_ERR(regmap); 202 202 } 203 203 204 204 data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);