Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging:r8188eu: remove GEN_CMD_CODE macro

GEN_CMD_CODE is redundant macro.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Ivan Safonov and committed by
Greg Kroah-Hartman
ae7f7aa0 2e2f78d0

+49 -51
+12 -12
drivers/staging/rtl8188eu/core/rtw_cmd.c
··· 85 85 /* To decide allow or not */ 86 86 if ((pcmdpriv->padapter->pwrctrlpriv.bHWPwrPindetect) && 87 87 (!pcmdpriv->padapter->registrypriv.usbss_enable)) { 88 - if (cmd_obj->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) { 88 + if (cmd_obj->cmdcode == _Set_Drv_Extra_CMD_) { 89 89 struct drvextra_cmd_parm *pdrvextra_cmd_parm = (struct drvextra_cmd_parm *)cmd_obj->parmbuf; 90 90 91 91 if (pdrvextra_cmd_parm->ec_id == POWER_SAVING_CTRL_WK_CID) ··· 93 93 } 94 94 } 95 95 96 - if (cmd_obj->cmdcode == GEN_CMD_CODE(_SetChannelPlan)) 96 + if (cmd_obj->cmdcode == _SetChannelPlan_CMD_) 97 97 bAllow = true; 98 98 99 99 if ((!pcmdpriv->padapter->hw_init_completed && !bAllow) || ··· 271 271 272 272 RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("%s: flush network queue\n", __func__)); 273 273 274 - init_h2fwcmd_w_parm_no_rsp(ph2c, psurveyPara, GEN_CMD_CODE(_SiteSurvey)); 274 + init_h2fwcmd_w_parm_no_rsp(ph2c, psurveyPara, _SiteSurvey_CMD_); 275 275 276 276 /* psurveyPara->bsslimit = 48; */ 277 277 psurveyPara->scan_mode = pmlmepriv->scan_mode; ··· 489 489 pcmd->cmdsz = get_wlan_bssid_ex_sz(psecnetwork);/* get cmdsz before endian conversion */ 490 490 491 491 INIT_LIST_HEAD(&pcmd->list); 492 - pcmd->cmdcode = _JoinBss_CMD_;/* GEN_CMD_CODE(_JoinBss) */ 492 + pcmd->cmdcode = _JoinBss_CMD_; 493 493 pcmd->parmbuf = (unsigned char *)psecnetwork; 494 494 pcmd->rsp = NULL; 495 495 pcmd->rspsz = 0; ··· 684 684 paddbareq_parm->tid = tid; 685 685 memcpy(paddbareq_parm->addr, addr, ETH_ALEN); 686 686 687 - init_h2fwcmd_w_parm_no_rsp(ph2c, paddbareq_parm, GEN_CMD_CODE(_AddBAReq)); 687 + init_h2fwcmd_w_parm_no_rsp(ph2c, paddbareq_parm, _AddBAReq_CMD_); 688 688 689 689 /* DBG_88E("rtw_addbareq_cmd, tid =%d\n", tid); */ 690 690 ··· 722 722 pdrvextra_cmd_parm->type_size = 0; 723 723 pdrvextra_cmd_parm->pbuf = (u8 *)padapter; 724 724 725 - init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra)); 725 + init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, _Set_Drv_Extra_CMD_); 726 726 727 727 728 728 /* rtw_enqueue_cmd(pcmdpriv, ph2c); */ ··· 765 765 goto exit; 766 766 } 767 767 768 - init_h2fwcmd_w_parm_no_rsp(pcmdobj, setChannelPlan_param, GEN_CMD_CODE(_SetChannelPlan)); 768 + init_h2fwcmd_w_parm_no_rsp(pcmdobj, setChannelPlan_param, _SetChannelPlan_CMD_); 769 769 res = rtw_enqueue_cmd(pcmdpriv, pcmdobj); 770 770 } else { 771 771 /* no need to enqueue, do the cmd hdl directly and free cmd parameter */ ··· 934 934 pdrvextra_cmd_parm->type_size = lps_ctrl_type; 935 935 pdrvextra_cmd_parm->pbuf = NULL; 936 936 937 - init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra)); 937 + init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, _Set_Drv_Extra_CMD_); 938 938 939 939 res = rtw_enqueue_cmd(pcmdpriv, ph2c); 940 940 } else { ··· 976 976 pdrvextra_cmd_parm->ec_id = RTP_TIMER_CFG_WK_CID; 977 977 pdrvextra_cmd_parm->type_size = min_time; 978 978 pdrvextra_cmd_parm->pbuf = NULL; 979 - init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra)); 979 + init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, _Set_Drv_Extra_CMD_); 980 980 res = rtw_enqueue_cmd(pcmdpriv, ph2c); 981 981 exit: 982 982 ··· 1018 1018 pdrvextra_cmd_parm->ec_id = ANT_SELECT_WK_CID; 1019 1019 pdrvextra_cmd_parm->type_size = antenna; 1020 1020 pdrvextra_cmd_parm->pbuf = NULL; 1021 - init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra)); 1021 + init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, _Set_Drv_Extra_CMD_); 1022 1022 1023 1023 res = rtw_enqueue_cmd(pcmdpriv, ph2c); 1024 1024 } else { ··· 1046 1046 1047 1047 pdrvextra_cmd_parm->ec_id = POWER_SAVING_CTRL_WK_CID; 1048 1048 pdrvextra_cmd_parm->pbuf = NULL; 1049 - init_h2fwcmd_w_parm_no_rsp(ppscmd, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra)); 1049 + init_h2fwcmd_w_parm_no_rsp(ppscmd, pdrvextra_cmd_parm, _Set_Drv_Extra_CMD_); 1050 1050 1051 1051 return rtw_enqueue_cmd(pcmdpriv, ppscmd); 1052 1052 } ··· 1117 1117 pdrvextra_cmd_parm->type_size = 0; 1118 1118 pdrvextra_cmd_parm->pbuf = NULL; 1119 1119 1120 - init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra)); 1120 + init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, _Set_Drv_Extra_CMD_); 1121 1121 1122 1122 res = rtw_enqueue_cmd(pcmdpriv, ph2c); 1123 1123 exit:
+7 -7
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
··· 4240 4240 4241 4241 INIT_LIST_HEAD(&pcmd_obj->list); 4242 4242 4243 - pcmd_obj->cmdcode = GEN_CMD_CODE(_Set_MLME_EVT); 4243 + pcmd_obj->cmdcode = _Set_MLME_EVT_CMD_; 4244 4244 pcmd_obj->cmdsz = cmdsz; 4245 4245 pcmd_obj->parmbuf = pevtcmd; 4246 4246 ··· 4290 4290 4291 4291 INIT_LIST_HEAD(&pcmd_obj->list); 4292 4292 4293 - pcmd_obj->cmdcode = GEN_CMD_CODE(_Set_MLME_EVT); 4293 + pcmd_obj->cmdcode = _Set_MLME_EVT_CMD_; 4294 4294 pcmd_obj->cmdsz = cmdsz; 4295 4295 pcmd_obj->parmbuf = pevtcmd; 4296 4296 ··· 4334 4334 4335 4335 INIT_LIST_HEAD(&pcmd_obj->list); 4336 4336 4337 - pcmd_obj->cmdcode = GEN_CMD_CODE(_Set_MLME_EVT); 4337 + pcmd_obj->cmdcode = _Set_MLME_EVT_CMD_; 4338 4338 pcmd_obj->cmdsz = cmdsz; 4339 4339 pcmd_obj->parmbuf = pevtcmd; 4340 4340 ··· 4385 4385 4386 4386 INIT_LIST_HEAD(&pcmd_obj->list); 4387 4387 4388 - pcmd_obj->cmdcode = GEN_CMD_CODE(_Set_MLME_EVT); 4388 + pcmd_obj->cmdcode = _Set_MLME_EVT_CMD_; 4389 4389 pcmd_obj->cmdsz = cmdsz; 4390 4390 pcmd_obj->parmbuf = pevtcmd; 4391 4391 ··· 4438 4438 4439 4439 INIT_LIST_HEAD(&pcmd_obj->list); 4440 4440 4441 - pcmd_obj->cmdcode = GEN_CMD_CODE(_Set_MLME_EVT); 4441 + pcmd_obj->cmdcode = _Set_MLME_EVT_CMD_; 4442 4442 pcmd_obj->cmdsz = cmdsz; 4443 4443 pcmd_obj->parmbuf = pevtcmd; 4444 4444 ··· 4849 4849 goto exit_survey_timer_hdl; 4850 4850 } 4851 4851 4852 - init_h2fwcmd_w_parm_no_rsp(ph2c, psurveyPara, GEN_CMD_CODE(_SiteSurvey)); 4852 + init_h2fwcmd_w_parm_no_rsp(ph2c, psurveyPara, _SiteSurvey_CMD_); 4853 4853 rtw_enqueue_cmd(pcmdpriv, ph2c); 4854 4854 } 4855 4855 ··· 5425 5425 pmlmeinfo->hidden_ssid_mode); 5426 5426 ptxBeacon_parm->IELength += len_diff; 5427 5427 5428 - init_h2fwcmd_w_parm_no_rsp(ph2c, ptxBeacon_parm, GEN_CMD_CODE(_TX_Beacon)); 5428 + init_h2fwcmd_w_parm_no_rsp(ph2c, ptxBeacon_parm, _TX_Beacon_CMD_); 5429 5429 5430 5430 res = rtw_enqueue_cmd(pcmdpriv, ph2c); 5431 5431
+30 -32
drivers/staging/rtl8188eu/include/rtw_cmd.h
··· 284 284 u8 channel_plan; 285 285 }; 286 286 287 - #define GEN_CMD_CODE(cmd) cmd ## _CMD_ 288 - 289 287 /* 290 288 291 289 Result: ··· 346 348 }; 347 349 348 350 enum rtw_h2c_cmd { 349 - GEN_CMD_CODE(_JoinBss), 350 - GEN_CMD_CODE(_DisConnect), 351 - GEN_CMD_CODE(_CreateBss), 352 - GEN_CMD_CODE(_SetOpMode), 353 - GEN_CMD_CODE(_SiteSurvey), 354 - GEN_CMD_CODE(_SetAuth), 355 - GEN_CMD_CODE(_SetKey), 356 - GEN_CMD_CODE(_SetStaKey), 357 - GEN_CMD_CODE(_SetAssocSta), 358 - GEN_CMD_CODE(_AddBAReq), 359 - GEN_CMD_CODE(_SetChannel), 360 - GEN_CMD_CODE(_TX_Beacon), 361 - GEN_CMD_CODE(_Set_MLME_EVT), 362 - GEN_CMD_CODE(_Set_Drv_Extra), 363 - GEN_CMD_CODE(_SetChannelPlan), 351 + _JoinBss_CMD_, 352 + _DisConnect_CMD_, 353 + _CreateBss_CMD_, 354 + _SetOpMode_CMD_, 355 + _SiteSurvey_CMD_, 356 + _SetAuth_CMD_, 357 + _SetKey_CMD_, 358 + _SetStaKey_CMD_, 359 + _SetAssocSta_CMD_, 360 + _AddBAReq_CMD_, 361 + _SetChannel_CMD_, 362 + _TX_Beacon_CMD_, 363 + _Set_MLME_EVT_CMD_, 364 + _Set_Drv_Extra_CMD_, 365 + _SetChannelPlan_CMD_, 364 366 365 367 MAX_H2CCMD 366 368 }; 367 369 368 370 #ifdef _RTW_CMD_C_ 369 371 static struct _cmd_callback rtw_cmd_callback[] = { 370 - {GEN_CMD_CODE(_JoinBss), &rtw_joinbss_cmd_callback}, 371 - {GEN_CMD_CODE(_DisConnect), &rtw_disassoc_cmd_callback}, 372 - {GEN_CMD_CODE(_CreateBss), &rtw_createbss_cmd_callback}, 373 - {GEN_CMD_CODE(_SetOpMode), NULL}, 374 - {GEN_CMD_CODE(_SiteSurvey), &rtw_survey_cmd_callback}, 375 - {GEN_CMD_CODE(_SetAuth), NULL}, 376 - {GEN_CMD_CODE(_SetKey), NULL}, 377 - {GEN_CMD_CODE(_SetStaKey), &rtw_setstaKey_cmdrsp_callback}, 378 - {GEN_CMD_CODE(_SetAssocSta), &rtw_setassocsta_cmdrsp_callback}, 379 - {GEN_CMD_CODE(_AddBAReq), NULL}, 380 - {GEN_CMD_CODE(_SetChannel), NULL}, 381 - {GEN_CMD_CODE(_TX_Beacon), NULL}, 382 - {GEN_CMD_CODE(_Set_MLME_EVT), NULL}, 383 - {GEN_CMD_CODE(_Set_Drv_Extra), NULL}, 384 - {GEN_CMD_CODE(_SetChannelPlan), NULL}, 372 + {_JoinBss_CMD_, &rtw_joinbss_cmd_callback}, 373 + {_DisConnect_CMD_, &rtw_disassoc_cmd_callback}, 374 + {_CreateBss_CMD_, &rtw_createbss_cmd_callback}, 375 + {_SetOpMode_CMD_, NULL}, 376 + {_SiteSurvey_CMD_, &rtw_survey_cmd_callback}, 377 + {_SetAuth_CMD_, NULL}, 378 + {_SetKey_CMD_, NULL}, 379 + {_SetStaKey_CMD_, &rtw_setstaKey_cmdrsp_callback}, 380 + {_SetAssocSta_CMD_, &rtw_setassocsta_cmdrsp_callback}, 381 + {_AddBAReq_CMD_, NULL}, 382 + {_SetChannel_CMD_, NULL}, 383 + {_TX_Beacon_CMD_, NULL}, 384 + {_Set_MLME_EVT_CMD_, NULL}, 385 + {_Set_Drv_Extra_CMD_, NULL}, 386 + {_SetChannelPlan_CMD_, NULL}, 385 387 }; 386 388 #endif 387 389