Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fs/direct-io.c: calculate fs_count correctly in get_more_blocks()

In get_more_blocks(), we use dio_count to calcuate fs_count and do some
tricky things to increase fs_count if dio_count isn't aligned. But
actually it still has some corner cases that can't be coverd. See the
following example:

dio_write foo -s 1024 -w 4096

(direct write 4096 bytes at offset 1024). The same goes if the offset
isn't aligned to fs_blocksize.

In this case, the old calculation counts fs_count to be 1, but actually we
will write into 2 different blocks (if fs_blocksize=4096). The old code
just works, since it will call get_block twice (and may have to allocate
and create extents twice for filesystems like ext4). So we'd better call
get_block just once with the proper fs_count.

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Tao Ma and committed by
Linus Torvalds
ae55e1aa 45dac90f

+4 -7
+4 -7
fs/direct-io.c
··· 580 580 { 581 581 int ret; 582 582 sector_t fs_startblk; /* Into file, in filesystem-sized blocks */ 583 + sector_t fs_endblk; /* Into file, in filesystem-sized blocks */ 583 584 unsigned long fs_count; /* Number of filesystem-sized blocks */ 584 - unsigned long dio_count;/* Number of dio_block-sized blocks */ 585 - unsigned long blkmask; 586 585 int create; 587 586 588 587 /* ··· 592 593 if (ret == 0) { 593 594 BUG_ON(sdio->block_in_file >= sdio->final_block_in_request); 594 595 fs_startblk = sdio->block_in_file >> sdio->blkfactor; 595 - dio_count = sdio->final_block_in_request - sdio->block_in_file; 596 - fs_count = dio_count >> sdio->blkfactor; 597 - blkmask = (1 << sdio->blkfactor) - 1; 598 - if (dio_count & blkmask) 599 - fs_count++; 596 + fs_endblk = (sdio->final_block_in_request - 1) >> 597 + sdio->blkfactor; 598 + fs_count = fs_endblk - fs_startblk + 1; 600 599 601 600 map_bh->b_state = 0; 602 601 map_bh->b_size = fs_count << dio->inode->i_blkbits;