Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork

Configure Feed

Select the types of activity you want to include in your feed.

cifs: smb2ops: Fix listxattr() when there are no EAs

As per listxattr(2):

On success, a nonnegative number is returned indicating the size
of the extended attribute name list. On failure, -1 is returned
and errno is set appropriately.

In SMB1, when the server returns an empty EA list through a listxattr(),
it will correctly return 0 as there are no EAs for the given file.

However, in SMB2+, it returns -ENODATA in listxattr() which is wrong since
the request and response were sent successfully, although there's no actual
EA for the given file.

This patch fixes listxattr() for SMB2+ by returning 0 in cifs_listxattr()
when the server returns an empty list of EAs.

Signed-off-by: Paulo Alcantara <palcantara@suse.de>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <smfrench@gmail.com>

authored by

Paulo Alcantara and committed by
Steve French
ae2cd7fb f7c43966

+6
+6
fs/cifs/smb2ops.c
··· 589 589 590 590 SMB2_close(xid, tcon, fid.persistent_fid, fid.volatile_fid); 591 591 592 + /* 593 + * If ea_name is NULL (listxattr) and there are no EAs, return 0 as it's 594 + * not an error. Otherwise, the specified ea_name was not found. 595 + */ 592 596 if (!rc) 593 597 rc = move_smb2_ea_to_cifs(ea_data, buf_size, smb2_data, 594 598 SMB2_MAX_EA_BUF, ea_name); 599 + else if (!ea_name && rc == -ENODATA) 600 + rc = 0; 595 601 596 602 kfree(smb2_data); 597 603 return rc;