Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: OLPC: Clean up names to match what OLPC actually uses

The cs5535-pms cell doesn't actually need to be cloned, so we can drop that
and simply have the olpc-xo1.c driver use "cs5535-pms" directly.

Also, rename the cs5535-acpi clones to what we actually use for the (currently
out-of-tree) SCI driver. In the process, that fixes a subtle bug in
olpc-xo1.c which broke powerdown on XO-1s.. olpc-xo1-ac-acpi was a typo, not
something that actually existed.

Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Andres Salomon <dilinger@queued.net>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

authored by

Daniel Drake and committed by
Samuel Ortiz
adfa4bd4 fa1df691

+7 -9
+6 -6
arch/x86/platform/olpc/olpc-xo1.c
··· 72 72 dev_err(&pdev->dev, "can't fetch device resource info\n"); 73 73 return -EIO; 74 74 } 75 - if (strcmp(pdev->name, "olpc-xo1-pms") == 0) 75 + if (strcmp(pdev->name, "cs5535-pms") == 0) 76 76 pms_base = res->start; 77 - else if (strcmp(pdev->name, "olpc-xo1-ac-acpi") == 0) 77 + else if (strcmp(pdev->name, "olpc-xo1-pm-acpi") == 0) 78 78 acpi_base = res->start; 79 79 80 80 /* If we have both addresses, we can override the poweroff hook */ ··· 90 90 { 91 91 mfd_cell_disable(pdev); 92 92 93 - if (strcmp(pdev->name, "olpc-xo1-pms") == 0) 93 + if (strcmp(pdev->name, "cs5535-pms") == 0) 94 94 pms_base = 0; 95 - else if (strcmp(pdev->name, "olpc-xo1-acpi") == 0) 95 + else if (strcmp(pdev->name, "olpc-xo1-pm-acpi") == 0) 96 96 acpi_base = 0; 97 97 98 98 pm_power_off = NULL; ··· 101 101 102 102 static struct platform_driver cs5535_pms_drv = { 103 103 .driver = { 104 - .name = "olpc-xo1-pms", 104 + .name = "cs5535-pms", 105 105 .owner = THIS_MODULE, 106 106 }, 107 107 .probe = olpc_xo1_probe, ··· 110 110 111 111 static struct platform_driver cs5535_acpi_drv = { 112 112 .driver = { 113 - .name = "olpc-xo1-acpi", 113 + .name = "olpc-xo1-pm-acpi", 114 114 .owner = THIS_MODULE, 115 115 }, 116 116 .probe = olpc_xo1_probe,
+1 -3
drivers/mfd/cs5535-mfd.c
··· 115 115 #ifdef CONFIG_OLPC 116 116 static void __devinit cs5535_clone_olpc_cells(void) 117 117 { 118 - const char *acpi_clones[] = { "olpc-xo1-acpi" }; 119 - const char *pms_clones[] = { "olpc-xo1-pms" }; 118 + const char *acpi_clones[] = { "olpc-xo1-pm-acpi", "olpc-xo1-sci-acpi" }; 120 119 121 120 if (!machine_is_olpc()) 122 121 return; 123 122 124 123 mfd_clone_cell("cs5535-acpi", acpi_clones, ARRAY_SIZE(acpi_clones)); 125 - mfd_clone_cell("cs5535-pms", pms_clones, ARRAY_SIZE(pms_clones)); 126 124 } 127 125 #else 128 126 static void cs5535_clone_olpc_cells(void) { }