Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

slab: don't put freepointer outside of object if only orig_size

The commit 946fa0dbf2d8 ("mm/slub: extend redzone check to extra
allocated kmalloc space than requested") will extend right redzone
when allocating for orig_size < object_size. So we can't overlay the
freepointer in the object space in this case.

But the code looks like it forgot to check SLAB_RED_ZONE, since there
won't be extended right redzone if only orig_size enabled.

As we are here, make this complex conditional expressions a little
prettier and add some comments about extending right redzone when
slub_debug_orig_size() enabled.

Reviewed-by: Feng Tang <feng.tang@intel.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Chengming Zhou <chengming.zhou@linux.dev>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

authored by

Chengming Zhou and committed by
Vlastimil Babka
adef2aea 47d911b0

+6 -5
+6 -5
mm/slub.c
··· 5167 5167 */ 5168 5168 s->inuse = size; 5169 5169 5170 - if (slub_debug_orig_size(s) || 5171 - (flags & (SLAB_TYPESAFE_BY_RCU | SLAB_POISON)) || 5172 - ((flags & SLAB_RED_ZONE) && s->object_size < sizeof(void *)) || 5173 - s->ctor) { 5170 + if ((flags & (SLAB_TYPESAFE_BY_RCU | SLAB_POISON)) || s->ctor || 5171 + ((flags & SLAB_RED_ZONE) && 5172 + (s->object_size < sizeof(void *) || slub_debug_orig_size(s)))) { 5174 5173 /* 5175 5174 * Relocate free pointer after the object if it is not 5176 5175 * permitted to overwrite the first word of the object on ··· 5177 5178 * 5178 5179 * This is the case if we do RCU, have a constructor or 5179 5180 * destructor, are poisoning the objects, or are 5180 - * redzoning an object smaller than sizeof(void *). 5181 + * redzoning an object smaller than sizeof(void *) or are 5182 + * redzoning an object with slub_debug_orig_size() enabled, 5183 + * in which case the right redzone may be extended. 5181 5184 * 5182 5185 * The assumption that s->offset >= s->inuse means free 5183 5186 * pointer is outside of the object is used in the