Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (occ/p9_sbe) Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918085951.1234172-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Uwe Kleine-König and committed by
Guenter Roeck
ade53919 13af7eee

+2 -4
+2 -4
drivers/hwmon/occ/p9_sbe.c
··· 167 167 return rc; 168 168 } 169 169 170 - static int p9_sbe_occ_remove(struct platform_device *pdev) 170 + static void p9_sbe_occ_remove(struct platform_device *pdev) 171 171 { 172 172 struct occ *occ = platform_get_drvdata(pdev); 173 173 struct p9_sbe_occ *ctx = to_p9_sbe_occ(occ); ··· 178 178 occ_shutdown(occ); 179 179 180 180 kvfree(ctx->ffdc); 181 - 182 - return 0; 183 181 } 184 182 185 183 static const struct of_device_id p9_sbe_occ_of_match[] = { ··· 193 195 .of_match_table = p9_sbe_occ_of_match, 194 196 }, 195 197 .probe = p9_sbe_occ_probe, 196 - .remove = p9_sbe_occ_remove, 198 + .remove_new = p9_sbe_occ_remove, 197 199 }; 198 200 199 201 module_platform_driver(p9_sbe_occ_driver);