Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic()

modprobe drm_hdmi_state_helper_test and then rmmod it, the following
memory leak occurs.

The `mode` allocated in drm_mode_duplicate() called by
drm_display_mode_from_cea_vic() is not freed, which cause the memory leak:

unreferenced object 0xffffff80ccd18100 (size 128):
comm "kunit_try_catch", pid 1851, jiffies 4295059695
hex dump (first 32 bytes):
57 62 00 00 80 02 90 02 f0 02 20 03 00 00 e0 01 Wb........ .....
ea 01 ec 01 0d 02 00 00 0a 00 00 00 00 00 00 00 ................
backtrace (crc c2f1aa95):
[<000000000f10b11b>] kmemleak_alloc+0x34/0x40
[<000000001cd4cf73>] __kmalloc_cache_noprof+0x26c/0x2f4
[<00000000f1f3cffa>] drm_mode_duplicate+0x44/0x19c
[<000000008cbeef13>] drm_display_mode_from_cea_vic+0x88/0x98
[<0000000019daaacf>] 0xffffffedc11ae69c
[<000000000aad0f85>] kunit_try_run_case+0x13c/0x3ac
[<00000000a9210bac>] kunit_generic_run_threadfn_adapter+0x80/0xec
[<000000000a0b2e9e>] kthread+0x2e8/0x374
[<00000000bd668858>] ret_from_fork+0x10/0x20
......

Free `mode` by using drm_kunit_display_mode_from_cea_vic()
to fix it.

Cc: stable@vger.kernel.org
Fixes: 4af70f19e559 ("drm/tests: Add RGB Quantization tests")
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241030023504.530425-4-ruanjinjie@huawei.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>

authored by

Jinjie Ruan and committed by
Maxime Ripard
add4163a 92616334

+4 -4
+4 -4
drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
··· 441 441 ctx = drm_kunit_helper_acquire_ctx_alloc(test); 442 442 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); 443 443 444 - mode = drm_display_mode_from_cea_vic(drm, 1); 444 + mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1); 445 445 KUNIT_ASSERT_NOT_NULL(test, mode); 446 446 447 447 drm = &priv->drm; ··· 555 555 ctx = drm_kunit_helper_acquire_ctx_alloc(test); 556 556 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); 557 557 558 - mode = drm_display_mode_from_cea_vic(drm, 1); 558 + mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1); 559 559 KUNIT_ASSERT_NOT_NULL(test, mode); 560 560 561 561 drm = &priv->drm; ··· 671 671 ctx = drm_kunit_helper_acquire_ctx_alloc(test); 672 672 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); 673 673 674 - mode = drm_display_mode_from_cea_vic(drm, 1); 674 + mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1); 675 675 KUNIT_ASSERT_NOT_NULL(test, mode); 676 676 677 677 drm = &priv->drm; ··· 1263 1263 ctx = drm_kunit_helper_acquire_ctx_alloc(test); 1264 1264 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); 1265 1265 1266 - mode = drm_display_mode_from_cea_vic(drm, 1); 1266 + mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1); 1267 1267 KUNIT_ASSERT_NOT_NULL(test, mode); 1268 1268 1269 1269 /*