clocksource/drivers/arm_arch_timer: Avoid infinite recursion when ftrace is enabled

On platforms with an arch timer erratum workaround, it's possible for
arch_timer_reg_read_stable() to recurse into itself when certain
tracing options are enabled, leading to stack overflows and related
problems.

For example, when PREEMPT_TRACER and FUNCTION_GRAPH_TRACER are
selected, it's possible to trigger this with:

$ mount -t debugfs nodev /sys/kernel/debug/
$ echo function_graph > /sys/kernel/debug/tracing/current_tracer

The problem is that in such cases, preempt_disable() instrumentation
attempts to acquire a timestamp via trace_clock(), resulting in a call
back to arch_timer_reg_read_stable(), and hence recursion.

This patch changes arch_timer_reg_read_stable() to use
preempt_{disable,enable}_notrace(), which avoids this.

This problem is similar to the fixed by upstream commit 96b3d28bf4
("sched/clock: Prevent tracing recursion in sched_clock_cpu()").

Fixes: 6acc71ccac71 ("arm64: arch_timer: Allows a CPU-specific erratum to only affect a subset of CPUs")
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

authored by Ding Tianhong and committed by Daniel Lezcano adb4f11e 599dc457

Changed files
+2 -2
arch
arm64
include
+2 -2
arch/arm64/include/asm/arch_timer.h
··· 65 65 u64 _val; \ 66 66 if (needs_unstable_timer_counter_workaround()) { \ 67 67 const struct arch_timer_erratum_workaround *wa; \ 68 - preempt_disable(); \ 68 + preempt_disable_notrace(); \ 69 69 wa = __this_cpu_read(timer_unstable_counter_workaround); \ 70 70 if (wa && wa->read_##reg) \ 71 71 _val = wa->read_##reg(); \ 72 72 else \ 73 73 _val = read_sysreg(reg); \ 74 - preempt_enable(); \ 74 + preempt_enable_notrace(); \ 75 75 } else { \ 76 76 _val = read_sysreg(reg); \ 77 77 } \