tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

scsi: ipr: Call scsi_done() directly

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-42-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Bart Van Assche and committed by
Martin K. Petersen acd3c42d 25e1d896

+5 -5
+5 -5
drivers/scsi/ipr.c
··· 866 866 scsi_cmd->result |= (DID_ERROR << 16); 867 867 868 868 scsi_dma_unmap(ipr_cmd->scsi_cmd); 869 - scsi_cmd->scsi_done(scsi_cmd); 869 + scsi_done(scsi_cmd); 870 870 if (ipr_cmd->eh_comp) 871 871 complete(ipr_cmd->eh_comp); 872 872 list_add_tail(&ipr_cmd->queue, &ipr_cmd->hrrq->hrrq_free_q); ··· 6065 6065 res->in_erp = 0; 6066 6066 } 6067 6067 scsi_dma_unmap(ipr_cmd->scsi_cmd); 6068 - scsi_cmd->scsi_done(scsi_cmd); 6068 + scsi_done(scsi_cmd); 6069 6069 if (ipr_cmd->eh_comp) 6070 6070 complete(ipr_cmd->eh_comp); 6071 6071 list_add_tail(&ipr_cmd->queue, &ipr_cmd->hrrq->hrrq_free_q); ··· 6502 6502 } 6503 6503 6504 6504 scsi_dma_unmap(ipr_cmd->scsi_cmd); 6505 - scsi_cmd->scsi_done(scsi_cmd); 6505 + scsi_done(scsi_cmd); 6506 6506 if (ipr_cmd->eh_comp) 6507 6507 complete(ipr_cmd->eh_comp); 6508 6508 list_add_tail(&ipr_cmd->queue, &ipr_cmd->hrrq->hrrq_free_q); ··· 6531 6531 scsi_dma_unmap(scsi_cmd); 6532 6532 6533 6533 spin_lock_irqsave(ipr_cmd->hrrq->lock, lock_flags); 6534 - scsi_cmd->scsi_done(scsi_cmd); 6534 + scsi_done(scsi_cmd); 6535 6535 if (ipr_cmd->eh_comp) 6536 6536 complete(ipr_cmd->eh_comp); 6537 6537 list_add_tail(&ipr_cmd->queue, &ipr_cmd->hrrq->hrrq_free_q); ··· 6685 6685 spin_lock_irqsave(hrrq->lock, hrrq_flags); 6686 6686 memset(scsi_cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE); 6687 6687 scsi_cmd->result = (DID_NO_CONNECT << 16); 6688 - scsi_cmd->scsi_done(scsi_cmd); 6688 + scsi_done(scsi_cmd); 6689 6689 spin_unlock_irqrestore(hrrq->lock, hrrq_flags); 6690 6690 return 0; 6691 6691 }