Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipv6: Remove useless parameter in __snmp6_fill_statsdev

The parameter items(is always ICMP6_MIB_MAX) is useless for __snmp6_fill_statsdev

Signed-off-by: Jia He <hejianet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jia He and committed by
David S. Miller
aca05671 07613873

+6 -6
+6 -6
net/ipv6/addrconf.c
··· 4961 4961 } 4962 4962 4963 4963 static inline void __snmp6_fill_statsdev(u64 *stats, atomic_long_t *mib, 4964 - int items, int bytes) 4964 + int bytes) 4965 4965 { 4966 4966 int i; 4967 - int pad = bytes - sizeof(u64) * items; 4967 + int pad = bytes - sizeof(u64) * ICMP6_MIB_MAX; 4968 4968 BUG_ON(pad < 0); 4969 4969 4970 4970 /* Use put_unaligned() because stats may not be aligned for u64. */ 4971 - put_unaligned(items, &stats[0]); 4972 - for (i = 1; i < items; i++) 4971 + put_unaligned(ICMP6_MIB_MAX, &stats[0]); 4972 + for (i = 1; i < ICMP6_MIB_MAX; i++) 4973 4973 put_unaligned(atomic_long_read(&mib[i]), &stats[i]); 4974 4974 4975 - memset(&stats[items], 0, pad); 4975 + memset(&stats[ICMP6_MIB_MAX], 0, pad); 4976 4976 } 4977 4977 4978 4978 static inline void __snmp6_fill_stats64(u64 *stats, void __percpu *mib, ··· 5005 5005 offsetof(struct ipstats_mib, syncp)); 5006 5006 break; 5007 5007 case IFLA_INET6_ICMP6STATS: 5008 - __snmp6_fill_statsdev(stats, idev->stats.icmpv6dev->mibs, ICMP6_MIB_MAX, bytes); 5008 + __snmp6_fill_statsdev(stats, idev->stats.icmpv6dev->mibs, bytes); 5009 5009 break; 5010 5010 } 5011 5011 }