Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/exynos: Use regular fbdev I/O helpers

Use the regular fbdev helpers for framebuffer I/O instead of DRM's
helpers. Exynos does not use damage handling, so DRM's fbdev helpers
are mere wrappers around the fbdev code.

By using fbdev helpers directly within each DRM fbdev emulation,
we can eventually remove DRM's wrapper functions entirely.

v4:
* use initializer macros for struct fb_ops
v3:
* don't reorder Makefile rules (Sam)
v2:
* use FB_IO_HELPERS option

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230530151228.22979-5-tzimmermann@suse.de

+5 -5
+1
drivers/gpu/drm/exynos/Kconfig
··· 7 7 select DRM_DISPLAY_HELPER if DRM_EXYNOS_DP 8 8 select DRM_KMS_HELPER 9 9 select VIDEOMODE_HELPERS 10 + select FB_IO_HELPERS if DRM_FBDEV_EMULATION 10 11 select SND_SOC_HDMI_CODEC if SND_SOC 11 12 help 12 13 Choose this option if you have a Samsung SoC Exynos chipset.
+4 -5
drivers/gpu/drm/exynos/exynos_drm_fbdev.c
··· 8 8 * Seung-Woo Kim <sw0312.kim@samsung.com> 9 9 */ 10 10 11 + #include <linux/fb.h> 12 + 11 13 #include <drm/drm_crtc_helper.h> 12 14 #include <drm/drm_drv.h> 13 15 #include <drm/drm_fb_helper.h> ··· 49 47 50 48 static const struct fb_ops exynos_drm_fb_ops = { 51 49 .owner = THIS_MODULE, 50 + __FB_DEFAULT_IO_OPS_RDWR, 52 51 DRM_FB_HELPER_DEFAULT_OPS, 52 + __FB_DEFAULT_IO_OPS_DRAW, 53 53 .fb_mmap = exynos_drm_fb_mmap, 54 - .fb_read = drm_fb_helper_cfb_read, 55 - .fb_write = drm_fb_helper_cfb_write, 56 - .fb_fillrect = drm_fb_helper_cfb_fillrect, 57 - .fb_copyarea = drm_fb_helper_cfb_copyarea, 58 - .fb_imageblit = drm_fb_helper_cfb_imageblit, 59 54 .fb_destroy = exynos_drm_fb_destroy, 60 55 }; 61 56