Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: twl4030_madc_battery: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918133700.1254499-29-u.kleine-koenig@pengutronix.de
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Uwe Kleine-König and committed by
Sebastian Reichel
ac51982b 83ef1dbc

+2 -4
+2 -4
drivers/power/supply/twl4030_madc_battery.c
··· 244 244 return ret; 245 245 } 246 246 247 - static int twl4030_madc_battery_remove(struct platform_device *pdev) 247 + static void twl4030_madc_battery_remove(struct platform_device *pdev) 248 248 { 249 249 struct twl4030_madc_battery *bat = platform_get_drvdata(pdev); 250 250 ··· 253 253 iio_channel_release(bat->channel_vbat); 254 254 iio_channel_release(bat->channel_ichg); 255 255 iio_channel_release(bat->channel_temp); 256 - 257 - return 0; 258 256 } 259 257 260 258 static struct platform_driver twl4030_madc_battery_driver = { ··· 260 262 .name = "twl4030_madc_battery", 261 263 }, 262 264 .probe = twl4030_madc_battery_probe, 263 - .remove = twl4030_madc_battery_remove, 265 + .remove_new = twl4030_madc_battery_remove, 264 266 }; 265 267 module_platform_driver(twl4030_madc_battery_driver); 266 268