tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

x86/vdso: Drop implicit common-page-size linker flag

GNU linker's -z common-page-size's default value is based on the target
architecture. arch/x86/entry/vdso/Makefile sets it to the architecture
default, which is implicit and redundant. Drop it.

Fixes: 2aae950b21e4 ("x86_64: Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu")
Reported-by: Dmitry Golovin <dima@golovin.in>
Reported-by: Bill Wendling <morbo@google.com>
Suggested-by: Dmitry Golovin <dima@golovin.in>
Suggested-by: Rui Ueyama <ruiu@google.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Andy Lutomirski <luto@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Fangrui Song <maskray@google.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
Link: https://bugs.llvm.org/show_bug.cgi?id=38774
Link: https://github.com/ClangBuiltLinux/linux/issues/31

authored by Nick Desaulniers and committed by Borislav Petkov ac3e233d 25896d07

options
unified split
Changed files
+2 -2
arch
x86
entry
vdso
Makefile
+2 -2
arch/x86/entry/vdso/Makefile
··· 47 47 CPPFLAGS_vdso.lds += -P -C 48 48 49 49 VDSO_LDFLAGS_vdso.lds = -m elf_x86_64 -soname linux-vdso.so.1 --no-undefined \ 50 - -z max-page-size=4096 -z common-page-size=4096 50 + -z max-page-size=4096 51 51 52 52 $(obj)/vdso64.so.dbg: $(obj)/vdso.lds $(vobjs) FORCE 53 53 $(call if_changed,vdso) ··· 98 98 99 99 CPPFLAGS_vdsox32.lds = $(CPPFLAGS_vdso.lds) 100 100 VDSO_LDFLAGS_vdsox32.lds = -m elf32_x86_64 -soname linux-vdso.so.1 \ 101 - -z max-page-size=4096 -z common-page-size=4096 101 + -z max-page-size=4096 102 102 103 103 # x32-rebranded versions 104 104 vobjx32s-y := $(vobjs-y:.o=-x32.o)