Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

serial: milbeaut_usio: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231110152927.70601-25-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
abf11a4b c4a5b262

+2 -4
+2 -4
drivers/tty/serial/milbeaut_usio.c
··· 552 552 return ret; 553 553 } 554 554 555 - static int mlb_usio_remove(struct platform_device *pdev) 555 + static void mlb_usio_remove(struct platform_device *pdev) 556 556 { 557 557 struct uart_port *port = &mlb_usio_ports[pdev->id]; 558 558 struct clk *clk = port->private_data; 559 559 560 560 uart_remove_one_port(&mlb_usio_uart_driver, port); 561 561 clk_disable_unprepare(clk); 562 - 563 - return 0; 564 562 } 565 563 566 564 static const struct of_device_id mlb_usio_dt_ids[] = { ··· 569 571 570 572 static struct platform_driver mlb_usio_driver = { 571 573 .probe = mlb_usio_probe, 572 - .remove = mlb_usio_remove, 574 + .remove_new = mlb_usio_remove, 573 575 .driver = { 574 576 .name = USIO_NAME, 575 577 .of_match_table = mlb_usio_dt_ids,