Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

watchdog: pcwd_usb: overflow in usb_pcwd_send_command()

We changed "buf" from being an array of 6 chars to being a pointer this
sizeof(buf) needs to be updated as well.

Fixes: 2ddb8089a7e5 ('watchdog: pcwd_usb: Use allocated buffer for usb_control_msg')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

authored by

Dan Carpenter and committed by
Wim Van Sebroeck
ab5bbdc7 0859ffc3

+2 -2
+2 -2
drivers/watchdog/pcwd_usb.c
··· 258 258 259 259 if (usb_control_msg(usb_pcwd->udev, usb_sndctrlpipe(usb_pcwd->udev, 0), 260 260 HID_REQ_SET_REPORT, HID_DT_REPORT, 261 - 0x0200, usb_pcwd->interface_number, buf, sizeof(buf), 262 - USB_COMMAND_TIMEOUT) != sizeof(buf)) { 261 + 0x0200, usb_pcwd->interface_number, buf, 6, 262 + USB_COMMAND_TIMEOUT) != 6) { 263 263 dbg("usb_pcwd_send_command: error in usb_control_msg for " 264 264 "cmd 0x%x 0x%x 0x%x\n", cmd, *msb, *lsb); 265 265 }