Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings

Fix several W=1 warnings
- Updated kernel-doc as needed
- Deleted unused local variable, it was assigned but never used

v2:
- Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-25-sam@ravnborg.org

+6 -5
+6 -5
drivers/video/fbdev/s3c-fb.c
··· 75 75 * @buf_size: Offset of buffer size registers. 76 76 * @buf_end: Offset of buffer end registers. 77 77 * @osd: The base for the OSD registers. 78 + * @osd_stride: stride of osd 78 79 * @palette: Address of palette memory, or 0 if none. 79 80 * @has_prtcon: Set if has PRTCON register. 80 81 * @has_shadowcon: Set if has SHADOWCON register. ··· 156 155 * @windata: The platform data supplied for the window configuration. 157 156 * @parent: The hardware that this window is part of. 158 157 * @fbinfo: Pointer pack to the framebuffer info for this window. 159 - * @varint: The variant information for this window. 158 + * @variant: The variant information for this window. 160 159 * @palette_buffer: Buffer/cache to hold palette entries. 161 160 * @pseudo_palette: For use in TRUECOLOUR modes for entries 0..15/ 162 161 * @index: The window number of this window. ··· 337 336 /** 338 337 * s3c_fb_calc_pixclk() - calculate the divider to create the pixel clock. 339 338 * @sfb: The hardware state. 340 - * @pixclock: The pixel clock wanted, in picoseconds. 339 + * @pixclk: The pixel clock wanted, in picoseconds. 341 340 * 342 341 * Given the specified pixel clock, work out the necessary divider to get 343 342 * close to the output frequency. ··· 734 733 * @red: The red field for the palette data. 735 734 * @green: The green field for the palette data. 736 735 * @blue: The blue field for the palette data. 737 - * @trans: The transparency (alpha) field for the palette data. 736 + * @transp: The transparency (alpha) field for the palette data. 738 737 * @info: The framebuffer being changed. 739 738 */ 740 739 static int s3c_fb_setcolreg(unsigned regno, ··· 1134 1133 1135 1134 /** 1136 1135 * s3c_fb_release_win() - release resources for a framebuffer window. 1136 + * @sfb: The base resources for the hardware. 1137 1137 * @win: The window to cleanup the resources for. 1138 1138 * 1139 1139 * Release the resources that where claimed for the hardware window, ··· 1162 1160 /** 1163 1161 * s3c_fb_probe_win() - register an hardware window 1164 1162 * @sfb: The base resources for the hardware 1163 + * @win_no: The window number 1165 1164 * @variant: The variant information for this window. 1166 1165 * @res: Pointer to where to place the resultant window. 1167 1166 * ··· 1173 1170 struct s3c_fb_win_variant *variant, 1174 1171 struct s3c_fb_win **res) 1175 1172 { 1176 - struct fb_var_screeninfo *var; 1177 1173 struct fb_videomode initmode; 1178 1174 struct s3c_fb_pd_win *windata; 1179 1175 struct s3c_fb_win *win; ··· 1200 1198 1201 1199 win = fbinfo->par; 1202 1200 *res = win; 1203 - var = &fbinfo->var; 1204 1201 win->variant = *variant; 1205 1202 win->fbinfo = fbinfo; 1206 1203 win->parent = sfb;