Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

memory: tegra: tegra124-emc: Add missing of_node_put()

for_each_child_of_node() performs an of_node_get() on each iteration, so
to break out of the loop an of_node_put() is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

for_each_child_of_node(..., n) {
... when != of_node_put(n)
when != e = n
(
return n;
|
+ of_node_put(n);
? return ...;
)
...
}
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

authored by

Amitoj Kaur Chawla and committed by
Thierry Reding
aafb197f 1a695a90

+3 -1
+3 -1
drivers/memory/tegra/tegra124-emc.c
··· 970 970 timing = &emc->timings[i++]; 971 971 972 972 err = load_one_timing_from_dt(emc, timing, child); 973 - if (err) 973 + if (err) { 974 + of_node_put(child); 974 975 return err; 976 + } 975 977 } 976 978 977 979 sort(emc->timings, emc->num_timings, sizeof(*timing), cmp_timings,