Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Revert "dt-bindings: usb: mtk-xhci: Make all clocks required"

This reverts commit ebc4969ae125e65fdb563f66f4bfa7aec95f7eb4. That
commit was supposed to make the binding better reflect the MediaTek XHCI
hardware block by requiring all clocks to be present. But doing that
also causes too much noise in the devicetrees, since it requires
updating old MediaTek DTs to add clock handles for the fixed clocks, and
going forward every new clock added to the binding would require even
more updates.

The commit also didn't update the example to match the changes, causing
additional warnings.

Instead let's keep the clocks optional so that old devicetrees can keep
omitting the fixed clocks, and we'll just add the clocks as required on
new DTs.

Fixes: ebc4969ae125 ("dt-bindings: usb: mtk-xhci: Make all clocks required")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://lore.kernel.org/r/20220708192605.43351-1-nfraprado@collabora.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Nícolas F. R. A. Prado and committed by
Greg Kroah-Hartman
aae7948d 421c8d9a

+3 -1
+3 -1
Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
··· 68 68 maxItems: 1 69 69 70 70 clocks: 71 + minItems: 1 71 72 items: 72 73 - description: Controller clock used by normal mode 73 74 - description: Reference clock used by low power mode etc ··· 77 76 - description: controller clock 78 77 79 78 clock-names: 79 + minItems: 1 80 80 items: 81 - - const: sys_ck 81 + - const: sys_ck # required, the following ones are optional 82 82 - const: ref_ck 83 83 - const: mcu_ck 84 84 - const: dma_ck