Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc: don't use ioremap_prot() nor __ioremap() unless really needed.

In many places, ioremap_prot() and __ioremap() can be replaced with
higher level functions like ioremap(), ioremap_coherent(),
ioremap_cache(), ioremap_wc() ...

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

authored by

Christophe Leroy and committed by
Michael Ellerman
aa91796e 402a5698

+10 -11
+1 -1
arch/powerpc/kernel/btext.c
··· 163 163 offset = ((unsigned long) dispDeviceBase) - base; 164 164 size = dispDeviceRowBytes * dispDeviceRect[3] + offset 165 165 + dispDeviceRect[0]; 166 - vbase = __ioremap(base, size, pgprot_val(pgprot_noncached_wc(__pgprot(0)))); 166 + vbase = ioremap_wc(base, size); 167 167 if (!vbase) 168 168 return; 169 169 logicalDisplayBase = vbase + offset;
+1 -1
arch/powerpc/kernel/crash_dump.c
··· 110 110 vaddr = __va(paddr); 111 111 csize = copy_oldmem_vaddr(vaddr, buf, csize, offset, userbuf); 112 112 } else { 113 - vaddr = __ioremap(paddr, PAGE_SIZE, 0); 113 + vaddr = ioremap_cache(paddr, PAGE_SIZE); 114 114 csize = copy_oldmem_vaddr(vaddr, buf, csize, offset, userbuf); 115 115 iounmap(vaddr); 116 116 }
+2 -2
arch/powerpc/platforms/85xx/smp.c
··· 216 216 217 217 /* Map the spin table */ 218 218 if (ioremappable) 219 - spin_table = ioremap_prot(*cpu_rel_addr, 220 - sizeof(struct epapr_spin_table), _PAGE_COHERENT); 219 + spin_table = ioremap_coherent(*cpu_rel_addr, 220 + sizeof(struct epapr_spin_table)); 221 221 else 222 222 spin_table = phys_to_virt(*cpu_rel_addr); 223 223
+1 -1
arch/powerpc/platforms/pasemi/dma_lib.c
··· 576 576 res.start = 0xfd800000; 577 577 res.end = res.start + 0x1000; 578 578 } 579 - dma_status = __ioremap(res.start, resource_size(&res), 0); 579 + dma_status = ioremap_cache(res.start, resource_size(&res)); 580 580 pci_dev_put(iob_pdev); 581 581 582 582 for (i = 0; i < MAX_TXCH; i++)
+1 -2
arch/powerpc/platforms/ps3/spu.c
··· 215 215 goto fail_ioremap; 216 216 } 217 217 218 - spu->local_store = (__force void *)ioremap_prot(spu->local_store_phys, 219 - LS_SIZE, pgprot_val(pgprot_noncached_wc(__pgprot(0)))); 218 + spu->local_store = (__force void *)ioremap_wc(spu->local_store_phys, LS_SIZE); 220 219 221 220 if (!spu->local_store) { 222 221 pr_debug("%s:%d: ioremap local_store failed\n",
+4 -4
arch/powerpc/sysdev/fsl_85xx_cache_sram.c
··· 107 107 goto out_free; 108 108 } 109 109 110 - cache_sram->base_virt = ioremap_prot(cache_sram->base_phys, 111 - cache_sram->size, _PAGE_COHERENT | PAGE_KERNEL); 110 + cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys, 111 + cache_sram->size); 112 112 if (!cache_sram->base_virt) { 113 - dev_err(&dev->dev, "%pOF: ioremap_prot failed\n", 114 - dev->dev.of_node); 113 + dev_err(&dev->dev, "%pOF: ioremap_coherent failed\n", 114 + dev->dev.of_node); 115 115 ret = -ENOMEM; 116 116 goto out_release; 117 117 }