Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: pinctrl-at91: Demote non-kerneldoc header and complete another

The documentation header for 'struct at91_pinctrl_mux_ops' was missing
entries for {g,s}et_drivestrength and {g,s}et_slewrate.

Fixes the following W=1 kernel build warning(s):

drivers/pinctrl/pinctrl-at91.c:77: warning: cannot understand function prototype: 'enum drive_strength_bit '
drivers/pinctrl/pinctrl-at91.c:187: warning: Function parameter or member 'get_drivestrength' not described in 'at91_pinctrl_mux_ops'
drivers/pinctrl/pinctrl-at91.c:187: warning: Function parameter or member 'set_drivestrength' not described in 'at91_pinctrl_mux_ops'
drivers/pinctrl/pinctrl-at91.c:187: warning: Function parameter or member 'get_slewrate' not described in 'at91_pinctrl_mux_ops'
drivers/pinctrl/pinctrl-at91.c:187: warning: Function parameter or member 'set_slewrate' not described in 'at91_pinctrl_mux_ops'

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Link: https://lore.kernel.org/r/20200713144930.1034632-18-lee.jones@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Lee Jones and committed by
Linus Walleij
aa78655d 898503ee

+5 -1
+5 -1
drivers/pinctrl/pinctrl-at91.c
··· 65 65 #define DEBOUNCE_VAL_SHIFT 17 66 66 #define DEBOUNCE_VAL (0x3fff << DEBOUNCE_VAL_SHIFT) 67 67 68 - /** 68 + /* 69 69 * These defines will translated the dt binding settings to our internal 70 70 * settings. They are not necessarily the same value as the register setting. 71 71 * The actual drive strength current of low, medium and high must be looked up ··· 161 161 * @set_pulldown: enable/disable pulldown 162 162 * @get_schmitt_trig: get schmitt trigger status 163 163 * @disable_schmitt_trig: disable schmitt trigger 164 + * @get_drivestrength: get driver strength 165 + * @set_drivestrength: set driver strength 166 + * @get_slewrate: get slew rate 167 + * @set_slewrate: set slew rate 164 168 * @irq_type: return irq type 165 169 */ 166 170 struct at91_pinctrl_mux_ops {