Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: gemini/sl3516-ce - Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Uwe Kleine-König and committed by
Herbert Xu
aa2f8e9a b0d49b30

+2 -4
+2 -4
drivers/crypto/gemini/sl3516-ce-core.c
··· 505 505 return err; 506 506 } 507 507 508 - static int sl3516_ce_remove(struct platform_device *pdev) 508 + static void sl3516_ce_remove(struct platform_device *pdev) 509 509 { 510 510 struct sl3516_ce_dev *ce = platform_get_drvdata(pdev); 511 511 ··· 518 518 #ifdef CONFIG_CRYPTO_DEV_SL3516_DEBUG 519 519 debugfs_remove_recursive(ce->dbgfs_dir); 520 520 #endif 521 - 522 - return 0; 523 521 } 524 522 525 523 static const struct of_device_id sl3516_ce_crypto_of_match_table[] = { ··· 528 530 529 531 static struct platform_driver sl3516_ce_driver = { 530 532 .probe = sl3516_ce_probe, 531 - .remove = sl3516_ce_remove, 533 + .remove_new = sl3516_ce_remove, 532 534 .driver = { 533 535 .name = "sl3516-crypto", 534 536 .pm = &sl3516_ce_pm_ops,