Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

arm64: dts: qcom: msm8998-yoshino: Use actual pin names for pin nodes

With the gpio-line-names in place coming from SONY themselves, we can
now make the pin nodes and their labels to more closely resemble the
actual thing. 4k has been renamed to four_k due to dtc limitations.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230314-topic-yoshino_gpio-v2-2-4cb80e187e38@linaro.org

authored by

Konrad Dybcio and committed by
Bjorn Andersson
a9eaa479 900007f2

+32 -33
+2 -2
arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-maple.dts
··· 22 22 enable-active-high; 23 23 gpio = <&pmi8998_gpios 10 GPIO_ACTIVE_HIGH>; 24 24 pinctrl-names = "default"; 25 - pinctrl-0 = <&disp_dvdd_en>; 25 + pinctrl-0 = <&four_k_disp_dcdc_en>; 26 26 }; 27 27 }; 28 28 ··· 60 60 "SPMI_I2C_SEL", 61 61 "NC"; 62 62 63 - disp_dvdd_en: disp-dvdd-en-active-state { 63 + four_k_disp_dcdc_en: 4k-disp-dcdc-en-state { 64 64 pins = "gpio10"; 65 65 function = "normal"; 66 66 bias-disable;
+30 -31
arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino.dtsi
··· 21 21 clocks { 22 22 div1_mclk: divclk1 { 23 23 compatible = "gpio-gate-clock"; 24 - pinctrl-0 = <&audio_mclk_pin>; 24 + pinctrl-0 = <&div_clk1>; 25 25 pinctrl-names = "default"; 26 26 clocks = <&rpmcc RPM_SMD_DIV_CLK1>; 27 27 #clock-cells = <0>; ··· 46 46 enable-active-high; 47 47 gpio = <&tlmm 21 GPIO_ACTIVE_HIGH>; 48 48 pinctrl-names = "default"; 49 - pinctrl-0 = <&cam0_vdig_default>; 49 + pinctrl-0 = <&main_cam_pwr_en>; 50 50 }; 51 51 52 52 cam1_vdig_vreg: cam1-vdig { ··· 56 56 enable-active-high; 57 57 gpio = <&tlmm 25 GPIO_ACTIVE_HIGH>; 58 58 pinctrl-names = "default"; 59 - pinctrl-0 = <&cam1_vdig_default>; 59 + pinctrl-0 = <&chat_cam_pwr_en>; 60 60 vin-supply = <&vreg_s3a_1p35>; 61 61 }; 62 62 ··· 67 67 enable-active-high; 68 68 gpio = <&pmi8998_gpios 1 GPIO_ACTIVE_HIGH>; 69 69 pinctrl-names = "default"; 70 - pinctrl-0 = <&cam_vio_default>; 70 + pinctrl-0 = <&main_cam_pwr_io_en>; 71 71 vin-supply = <&vreg_lvs1a_1p8>; 72 72 }; 73 73 ··· 92 92 id-gpio = <&tlmm 38 GPIO_ACTIVE_HIGH>; 93 93 vbus-gpio = <&tlmm 128 GPIO_ACTIVE_HIGH>; 94 94 pinctrl-names = "default"; 95 - pinctrl-0 = <&usb_extcon_active &usb_vbus_active>; 95 + pinctrl-0 = <&cc_dir_default &usb_detect_en>; 96 96 }; 97 97 98 98 gpio-keys { 99 99 compatible = "gpio-keys"; 100 100 label = "Side buttons"; 101 101 pinctrl-names = "default"; 102 - pinctrl-0 = <&vol_down_pin_a>, <&cam_focus_pin_a>, 103 - <&cam_snapshot_pin_a>; 102 + pinctrl-0 = <&vol_down_n &focus_n &snapshot_n>; 104 103 button-vol-down { 105 104 label = "Volume Down"; 106 105 gpios = <&pm8998_gpios 5 GPIO_ACTIVE_LOW>; ··· 130 131 compatible = "gpio-keys"; 131 132 label = "Hall sensors"; 132 133 pinctrl-names = "default"; 133 - pinctrl-0 = <&hall_sensor0_default>; 134 + pinctrl-0 = <&acc_cover_open>; 134 135 135 136 event-hall-sensor0 { 136 137 label = "Cover Hall Sensor"; ··· 188 189 compatible = "gpio-vibrator"; 189 190 enable-gpios = <&pmi8998_gpios 5 GPIO_ACTIVE_HIGH>; 190 191 pinctrl-names = "default"; 191 - pinctrl-0 = <&vib_default>; 192 + pinctrl-0 = <&vib_ldo_en>; 192 193 }; 193 194 }; 194 195 ··· 262 263 vdd-supply = <&cam_vio_vreg>; 263 264 264 265 pinctrl-names = "default"; 265 - pinctrl-0 = <&tof_int &tof_reset>; 266 + pinctrl-0 = <&tof_int_n &tof_reset>; 266 267 }; 267 268 }; 268 269 ··· 337 338 "OPTION_2 (DISALLOWED)", 338 339 "PM_SLB (DISALLOWED)"; 339 340 340 - vol_down_pin_a: vol-down-active-state { 341 + vol_down_n: vol-down-n-state { 341 342 pins = "gpio5"; 342 343 function = PMIC_GPIO_FUNC_NORMAL; 343 344 bias-pull-up; ··· 345 346 qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>; 346 347 }; 347 348 348 - cam_focus_pin_a: cam-focus-btn-active-state { 349 + focus_n: focus-n-state { 349 350 pins = "gpio7"; 350 351 function = PMIC_GPIO_FUNC_NORMAL; 351 352 bias-pull-up; ··· 353 354 qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>; 354 355 }; 355 356 356 - cam_snapshot_pin_a: cam-snapshot-btn-active-state { 357 + snapshot_n: snapshot-n-state { 357 358 pins = "gpio8"; 358 359 function = PMIC_GPIO_FUNC_NORMAL; 359 360 bias-pull-up; ··· 361 362 qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>; 362 363 }; 363 364 364 - audio_mclk_pin: audio-mclk-pin-active-state { 365 + div_clk1: div-clk1-state { 365 366 pins = "gpio13"; 366 367 function = "func2"; 367 368 power-source = <0>; ··· 384 385 "SPMI_I2C_SEL", 385 386 "NC"; 386 387 387 - cam_vio_default: cam-vio-active-state { 388 + main_cam_pwr_io_en: main-cam-pwr-io-en-state { 388 389 pins = "gpio1"; 389 390 function = PMIC_GPIO_FUNC_NORMAL; 390 391 bias-disable; ··· 394 395 power-source = <1>; 395 396 }; 396 397 397 - vib_default: vib-en-state { 398 + vib_ldo_en: vib-ldo-en-state { 398 399 pins = "gpio5"; 399 400 function = PMIC_GPIO_FUNC_NORMAL; 400 401 bias-disable; ··· 789 790 "RFFE1_DATA", 790 791 "RFFE1_CLK"; 791 792 792 - mdp_vsync_n: mdp-vsync-n-state { 793 + mdp_vsync_p: mdp-vsync-p-state { 793 794 pins = "gpio10"; 794 795 function = "mdp_vsync_a"; 795 796 drive-strength = <2>; ··· 804 805 output-low; 805 806 }; 806 807 807 - msm_mclk0_default: msm-mclk0-active-state { 808 + cam_mclk0_active: cam-mclk0-active-state { 808 809 pins = "gpio13"; 809 810 function = "cam_mclk"; 810 811 drive-strength = <2>; 811 812 bias-disable; 812 813 }; 813 814 814 - msm_mclk1_default: msm-mclk1-active-state { 815 + cam_mclk1_active: cam-mclk1-active-state { 815 816 pins = "gpio14"; 816 817 function = "cam_mclk"; 817 818 drive-strength = <2>; ··· 832 833 drive-strength = <2>; 833 834 }; 834 835 835 - cam0_vdig_default: cam0-vdig-default-state { 836 + main_cam_pwr_en: main-cam-pwr-en-default-state { 836 837 pins = "gpio21"; 837 838 function = "gpio"; 838 839 bias-disable; 839 840 drive-strength = <2>; 840 841 }; 841 842 842 - tof_int: tof-int-state { 843 + tof_int_n: tof-int-n-state { 843 844 pins = "gpio22"; 844 845 function = "gpio"; 845 846 bias-pull-up; ··· 847 848 input-enable; 848 849 }; 849 850 850 - cam1_vdig_default: cam1-vdig-default-state { 851 + chat_cam_pwr_en: chat-cam-pwr-en-default-state { 851 852 pins = "gpio25"; 852 853 function = "gpio"; 853 854 bias-disable; 854 855 drive-strength = <2>; 855 - }; 856 - 857 - usb_extcon_active: usb-extcon-active-state { 858 - pins = "gpio38"; 859 - function = "gpio"; 860 - bias-disable; 861 - drive-strength = <16>; 862 856 }; 863 857 864 858 tof_reset: tof-reset-state { ··· 861 869 drive-strength = <2>; 862 870 }; 863 871 864 - hall_sensor0_default: acc-cover-open-state { 872 + cc_dir_default: cc-dir-active-state { 873 + pins = "gpio38"; 874 + function = "gpio"; 875 + bias-disable; 876 + drive-strength = <16>; 877 + }; 878 + 879 + acc_cover_open: acc-cover-open-state { 865 880 pins = "gpio124"; 866 881 function = "gpio"; 867 882 bias-disable; ··· 883 884 bias-pull-up; 884 885 }; 885 886 886 - usb_vbus_active: usb-vbus-active-state { 887 + usb_detect_en: usb-detect-en-active-state { 887 888 pins = "gpio128"; 888 889 function = "gpio"; 889 890 bias-disable;