Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/pm2fb: Initialize fb_ops to fbdev I/O-memory helpers

Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-27-tzimmermann@suse.de

+3
+1
drivers/video/fbdev/Kconfig
··· 94 94 select FB_CFB_FILLRECT 95 95 select FB_CFB_COPYAREA 96 96 select FB_CFB_IMAGEBLIT 97 + select FB_IOMEM_FOPS 97 98 select VIDEO_NOMODESET 98 99 help 99 100 This is the frame buffer device driver for cards based on
+2
drivers/video/fbdev/pm2fb.c
··· 1492 1492 1493 1493 static const struct fb_ops pm2fb_ops = { 1494 1494 .owner = THIS_MODULE, 1495 + __FB_DEFAULT_IOMEM_OPS_RDWR, 1495 1496 .fb_check_var = pm2fb_check_var, 1496 1497 .fb_set_par = pm2fb_set_par, 1497 1498 .fb_setcolreg = pm2fb_setcolreg, ··· 1503 1502 .fb_imageblit = pm2fb_imageblit, 1504 1503 .fb_sync = pm2fb_sync, 1505 1504 .fb_cursor = pm2fb_cursor, 1505 + __FB_DEFAULT_IOMEM_OPS_MMAP, 1506 1506 }; 1507 1507 1508 1508 /*