Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/amd/amdgpu_dm/mst: Remove useless sideband tracing

We already trace DPCD reads/writes on both MST and SST, there's no
reason to have this code here (plus, toggling these things with a
define at the top of the file isn't how we do things in the kernel).

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Lyude Paul and committed by
Alex Deucher
a98c4cd9 a500194e

-43
-43
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
··· 41 41 #include "amdgpu_dm_debugfs.h" 42 42 #endif 43 43 44 - 45 44 #if defined(CONFIG_DRM_AMD_DC_DCN) 46 45 #include "dc/dcn20/dcn20_resource.h" 47 - #endif 48 - 49 - /* #define TRACE_DPCD */ 50 - 51 - #ifdef TRACE_DPCD 52 - #define SIDE_BAND_MSG(address) (address >= DP_SIDEBAND_MSG_DOWN_REQ_BASE && address < DP_SINK_COUNT_ESI) 53 - 54 - static inline char *side_band_msg_type_to_str(uint32_t address) 55 - { 56 - static char str[10] = {0}; 57 - 58 - if (address < DP_SIDEBAND_MSG_UP_REP_BASE) 59 - strcpy(str, "DOWN_REQ"); 60 - else if (address < DP_SIDEBAND_MSG_DOWN_REP_BASE) 61 - strcpy(str, "UP_REP"); 62 - else if (address < DP_SIDEBAND_MSG_UP_REQ_BASE) 63 - strcpy(str, "DOWN_REP"); 64 - else 65 - strcpy(str, "UP_REQ"); 66 - 67 - return str; 68 - } 69 - 70 - static void log_dpcd(uint8_t type, 71 - uint32_t address, 72 - uint8_t *data, 73 - uint32_t size, 74 - bool res) 75 - { 76 - DRM_DEBUG_KMS("Op: %s, addr: %04x, SideBand Msg: %s, Op res: %s\n", 77 - (type == DP_AUX_NATIVE_READ) || 78 - (type == DP_AUX_I2C_READ) ? 79 - "Read" : "Write", 80 - address, 81 - SIDE_BAND_MSG(address) ? 82 - side_band_msg_type_to_str(address) : "Nop", 83 - res ? "OK" : "Fail"); 84 - 85 - if (res) { 86 - print_hex_dump(KERN_INFO, "Body: ", DUMP_PREFIX_NONE, 16, 1, data, size, false); 87 - } 88 - } 89 46 #endif 90 47 91 48 static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,