Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mga_dma: return 'err' not just zero from mga_do_cleanup_dma()

While reading some code I stumbled across the use of 'err' in
drivers/char/drm/mga_dma.c::mga_do_cleanup_dma() and I think there's a small
problem.

The variable is only used inside #if __OS_HAS_AGP which is fine, but all that
ever happens is an assignment to the variable - it is never actually used for
anything. The variable is nicely initialized to zero which is also what the
return statement at the end of function returns (always at the moment).

It looks to me like that function should be returning 'err' instead of always
just returning 0. Here's a patch to do that.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Airlie <airlied@linux.ie>

authored by

Jesper Juhl and committed by
Dave Airlie
a96ca105 e3236a11

+1 -1
+1 -1
drivers/char/drm/mga_dma.c
··· 998 998 } 999 999 } 1000 1000 1001 - return 0; 1001 + return err; 1002 1002 } 1003 1003 1004 1004 int mga_dma_init(struct drm_device *dev, void *data,