Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers: base: transport_class: fix possible memory leak

Current some drivers(like iscsi) call transport_register_device()
failed, they don't call transport_destroy_device() to release the
memory allocated in transport_setup_device(), because they don't
know what was done, it should be internal thing to release the
resource in register function. So fix this leak by calling destroy
function inside register function.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221110102307.3492557-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Yang Yingliang and committed by
Greg Kroah-Hartman
a8636780 0d150f96

+7 -1
+7 -1
include/linux/transport_class.h
··· 70 70 static inline int 71 71 transport_register_device(struct device *dev) 72 72 { 73 + int ret; 74 + 73 75 transport_setup_device(dev); 74 - return transport_add_device(dev); 76 + ret = transport_add_device(dev); 77 + if (ret) 78 + transport_destroy_device(dev); 79 + 80 + return ret; 75 81 } 76 82 77 83 static inline void