Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tools: usb: testusb: update default vary for superspeed

Currently, default vary will not accomodate superspeed endpoints
causing unexpected babble errors in the IN direction. Let's update
default 'vary' parameter so that we can maintain a "short-less"
transfer as hinted at the comment.

Reported-by: Ammy Yi <ammy.yi@intel.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

+9 -7
+9 -7
tools/usb/testusb.c
··· 387 387 /* pick defaults that works with all speeds, without short packets. 388 388 * 389 389 * Best per-frame data rates: 390 - * high speed, bulk 512 * 13 * 8 = 53248 391 - * interrupt 1024 * 3 * 8 = 24576 392 - * full speed, bulk/intr 64 * 19 = 1216 393 - * interrupt 64 * 1 = 64 394 - * low speed, interrupt 8 * 1 = 8 390 + * super speed,bulk 1024 * 16 * 8 = 131072 391 + * interrupt 1024 * 3 * 8 = 24576 392 + * high speed, bulk 512 * 13 * 8 = 53248 393 + * interrupt 1024 * 3 * 8 = 24576 394 + * full speed, bulk/intr 64 * 19 = 1216 395 + * interrupt 64 * 1 = 64 396 + * low speed, interrupt 8 * 1 = 8 395 397 */ 396 398 param.iterations = 1000; 397 399 param.length = 1024; 398 - param.vary = 512; 400 + param.vary = 1024; 399 401 param.sglen = 32; 400 402 401 403 /* for easy use when hotplugging */ ··· 459 457 "\t-c iterations default 1000\n" 460 458 "\t-s transfer length default 1024\n" 461 459 "\t-g sglen default 32\n" 462 - "\t-v vary default 512\n", 460 + "\t-v vary default 1024\n", 463 461 argv[0]); 464 462 return 1; 465 463 }