Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: dt-bindings: mt6358: Merge ldo_vcn33_* regulators

The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
regulator, having the same voltage setting and output pin. There are
simply two enable bits that are ORed together to enable the regulator.

Having two regulators representing the same output pin is misleading
from a design matching standpoint, and also error-prone in driver
implementations.

Merge the two as ldo_vcn33. Neither vcn33 regulators are referenced
in upstream device trees. As far as hardware designs go, none of the
Chromebooks using MT8183 w/ MT6358 use this output.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Link: https://lore.kernel.org/r/20230609083009.2822259-2-wenst@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Chen-Yu Tsai and committed by
Mark Brown
a74d4c57 d692cc61

+3 -11
+3 -11
Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
··· 15 15 ldo_vcamd, ldo_vcn18, ldo_vfe28, ldo_vsram_proc11, ldo_vcn28, ldo_vsram_others, 16 16 ldo_vsram_others_sshub, ldo_vsram_gpu, ldo_vxo22, ldo_vefuse, ldo_vaux18, 17 17 ldo_vmch, ldo_vbif28, ldo_vsram_proc12, ldo_vcama1, ldo_vemc, ldo_vio28, ldo_va12, 18 - ldo_vrf18, ldo_vcn33_bt, ldo_vcn33_wifi, ldo_vcama2, ldo_vmc, ldo_vldo28, ldo_vaud28, 19 - ldo_vsim2 18 + ldo_vrf18, ldo_vcn33, ldo_vcama2, ldo_vmc, ldo_vldo28, ldo_vaud28, ldo_vsim2 20 19 21 20 Example: 22 21 ··· 304 305 regulator-enable-ramp-delay = <120>; 305 306 }; 306 307 307 - mt6358_vcn33_bt_reg: ldo_vcn33_bt { 308 - regulator-name = "vcn33_bt"; 309 - regulator-min-microvolt = <3300000>; 310 - regulator-max-microvolt = <3500000>; 311 - regulator-enable-ramp-delay = <270>; 312 - }; 313 - 314 - mt6358_vcn33_wifi_reg: ldo_vcn33_wifi { 315 - regulator-name = "vcn33_wifi"; 308 + mt6358_vcn33_reg: ldo_vcn33 { 309 + regulator-name = "vcn33"; 316 310 regulator-min-microvolt = <3300000>; 317 311 regulator-max-microvolt = <3500000>; 318 312 regulator-enable-ramp-delay = <270>;